From b3a9ee3d846640f4cc447ca97bc305daea7464b2 Mon Sep 17 00:00:00 2001 From: Jason Ge Date: Wed, 13 Jul 2011 16:33:18 -0700 Subject: [PATCH] Setting default minimumSeverity to zero from null Summary: In hphp's version of idx, it uses debug_rlog() which is not available in phabricator's code. It will be executed if null is passed as the second value to idx. Test Plan: ran arc lint which still report error message, and php ./scripts/arcanist.php unit src/lint/linter/xhpast/__test__ doesn't throw. Reviewed By: epriestley Reviewers: tuomaspelkonen, epriestley CC: aran, jungejason, epriestley Differential Revision: 666 --- src/lint/engine/base/ArcanistLintEngine.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lint/engine/base/ArcanistLintEngine.php b/src/lint/engine/base/ArcanistLintEngine.php index 84ff3357..6f98259b 100644 --- a/src/lint/engine/base/ArcanistLintEngine.php +++ b/src/lint/engine/base/ArcanistLintEngine.php @@ -65,7 +65,7 @@ abstract class ArcanistLintEngine { protected $charToLine = array(); protected $lineToFirstChar = array(); private $results = array(); - private $minimumSeverity = null; + private $minimumSeverity = ArcanistLintSeverity::SEVERITY_DISABLED; private $changedLines = array(); private $commitHookMode = false;