revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-29 18:22:41 +01:00
Code Issues Releases Wiki Activity

Temporarily unrequire defining getWorkflowName()

Browse source 
Summary:
We need to run new Arcanist over old code in Perflab.
We also need to run new Arcanist over new code (with already deleted custom `buildAllWorkflows()`).

This will work because old code overwrites `buildAllWorkflows()`.

Test Plan:
  $ arc help
  $ arc help # after deleting getWorkflowName() from one workflow

Reviewers: edward, epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D3741
This commit is contained in:
vrana 2012-10-19 10:38:34 -07:00
parent 94d283a453
commit b52ee2fdee
2 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/configuration/ArcanistConfiguration.php
View file

@ -58,6 +58,13 @@ class ArcanistConfiguration {
foreach ($symbols as $symbol) { foreach ($symbols as $symbol) {
$class = $symbol['name']; $class = $symbol['name'];
$workflow = newv($class, array()); $workflow = newv($class, array());
// TODO: Delete after installations will update (2012-10-31).
if (!method_exists($workflow, 'getWorkflowName')) {
// This workflow was hopefully already built by our parent.
continue;
}
$name = $workflow->getWorkflowName(); $name = $workflow->getWorkflowName();
if (isset($workflows[$name])) { if (isset($workflows[$name])) {

3
src/workflow/ArcanistBaseWorkflow.php
View file

@ -89,7 +89,8 @@ abstract class ArcanistBaseWorkflow {
* *
* @return string The command a user types to invoke this workflow. * @return string The command a user types to invoke this workflow.
*/ */
abstract public function getWorkflowName(); // TODO: Uncomment after installations will update (2012-10-31).
// abstract public function getWorkflowName();
/** /**
* Return console formatted string with all command synopses. * Return console formatted string with all command synopses.