From b56634ad2746f53ef8bea22be904c99c73d3fb0d Mon Sep 17 00:00:00 2001 From: Eric Stern Date: Fri, 26 Jul 2013 19:09:09 -0700 Subject: [PATCH] Pass correct filename into PHPUnitTestEngine coverage Summary: The test result parser in PhpunitTestEngine was receiving $test_path from the previous loop instead of $path from the current one. The variable isn't actually used in the PhpunitResultParser object (it exists for strict compatibility with the parent class) so it didn't cause any problems, but who knows if that could change in the future Test Plan: Review diff. No changes to the output of running 'arc unit' when using the Phpunit engine, as expected Reviewers: epriestley CC: aran, epriestley, aurelijus, chad Differential Revision: https://secure.phabricator.com/D6587 --- src/unit/engine/PhpunitTestEngine.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/unit/engine/PhpunitTestEngine.php b/src/unit/engine/PhpunitTestEngine.php index a7872982..a4f05c38 100644 --- a/src/unit/engine/PhpunitTestEngine.php +++ b/src/unit/engine/PhpunitTestEngine.php @@ -85,7 +85,8 @@ final class PhpunitTestEngine extends ArcanistBaseUnitTestEngine { list($err, $stdout, $stderr) = $future->resolve(); - $results[] = $this->parseTestResults($test_path, + $results[] = $this->parseTestResults( + $test, $tmpfiles[$test]['json'], $tmpfiles[$test]['clover']); }