mirror of
https://we.phorge.it/source/arcanist.git
synced 2024-11-21 22:32:41 +01:00
Make retrieving parents for mercurial commits work consistently across platforms
Summary: Currently the template is single quoted, but Windows only supports double quotes. This meant that the output would be like: lang=text 'aabbccddeeffaabbccddeeffaabbccddeeff0123 ' Which is clearly wrong. This is displayed like that in Phabricator as well, which is confusing. Test Plan: ran `arc diff` on a Windows machine and saw the correct behaviour. Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9450
This commit is contained in:
parent
57f4bbae42
commit
b60eaa6487
1 changed files with 2 additions and 1 deletions
|
@ -266,7 +266,8 @@ final class ArcanistMercurialAPI extends ArcanistRepositoryAPI {
|
|||
// We didn't get a cheap hit on previous commit, so do the full-cost
|
||||
// "hg parents" call. We can run these in parallel, at least.
|
||||
$futures[$node] = $this->execFutureLocal(
|
||||
"parents --template='{node}\\n' --rev %s",
|
||||
'parents --template %s --rev %s',
|
||||
'{node}\n',
|
||||
$node);
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in a new issue