revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-22 14:52:40 +01:00
Code Issues Releases Wiki Activity

Make retrieving parents for mercurial commits work consistently across platforms

Browse source 
Summary:
Currently the template is single quoted, but Windows only supports double quotes. This meant that the output would be like:
  lang=text
  'aabbccddeeffaabbccddeeffaabbccddeeff0123
  '

Which is clearly wrong.

This is displayed like that in Phabricator as well, which is confusing.

Test Plan: ran `arc diff` on a Windows machine and saw the correct behaviour.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D9450
This commit is contained in:
Richard van Velzen 2014-06-10 10:20:39 -07:00 committed by epriestley
parent 57f4bbae42
commit b60eaa6487
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/repository/api/ArcanistMercurialAPI.php
View file

@ -266,7 +266,8 @@ final class ArcanistMercurialAPI extends ArcanistRepositoryAPI {
// We didn't get a cheap hit on previous commit, so do the full-cost // We didn't get a cheap hit on previous commit, so do the full-cost
// "hg parents" call. We can run these in parallel, at least. // "hg parents" call. We can run these in parallel, at least.
$futures[$node] = $this->execFutureLocal( $futures[$node] = $this->execFutureLocal(
"parents --template='{node}\\n' --rev %s", 'parents --template %s --rev %s',
'{node}\n',
$node); $node);
} }