revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-29 18:22:41 +01:00
Code Issues Releases Wiki Activity

Fix arc patch adding unnecessary files for hg repos

Browse source 
Summary:
Arc patch was committing with -A (--addremove) which meant any random
files that were sitting around in the repo (like conflict .orig files) were
added to the commit.  The -A isn't even necessary since the hg import
adds and removes all the appropriate files for you.

Test Plan:
touch foo
arc patch --diff some-diff-id
Verified that foo was not added to the commit

Reviewers: epriestley, nh

Reviewed By: epriestley

CC: dschleimer, bos, sid0, aran, Korvin

Differential Revision: https://secure.phabricator.com/D5396
This commit is contained in:
durham 2013-03-20 14:40:28 -07:00
parent 30e12a0c9a
commit b6e83c7b35
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/workflow/ArcanistPatchWorkflow.php
View file

@ -773,7 +773,7 @@ EOTEXT
$commit_message = $this->getCommitMessage($bundle); $commit_message = $this->getCommitMessage($bundle);
$future = $repository_api->execFutureLocal( $future = $repository_api->execFutureLocal(
'commit -A %C -l -', 'commit %C -l -',
$author_cmd); $author_cmd);
$future->write($commit_message); $future->write($commit_message);
$future->resolvex(); $future->resolvex();