revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-25 08:12:40 +01:00
Code Issues Releases Wiki Activity

Work around an issue with older diffs in the Facebook database.

Browse source 
Summary: We have some diffs which predate property tracking and are shipping
down sketch data, work around it in the client for now.

Test Plan:

Reviewers:

CC:
This commit is contained in:
epriestley 2011-01-10 14:15:08 -08:00
parent 9e77d3b3ba
commit b7ccb78ece
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/parser/diff/change/ArcanistDiffChange.php
View file

@ -63,9 +63,11 @@ class ArcanistDiffChange {
$obj->metdadata = $dict['metadata']; $obj->metdadata = $dict['metadata'];
$obj->oldPath = $dict['oldPath']; $obj->oldPath = $dict['oldPath'];
$obj->currentPath = $dict['currentPath']; $obj->currentPath = $dict['currentPath'];
$obj->awayPaths = $dict['awayPaths']; // TODO: The backend is shipping down some bogus data, e.g. diff 199453.
$obj->oldProperties = $dict['oldProperties']; // Should probably clean this up.
$obj->newProperties = $dict['newProperties']; $obj->awayPaths = nonempty($dict['awayPaths'], array());
$obj->oldProperties = nonempty($dict['oldProperties'], array());
$obj->newProperties = nonempty($dict['newProperties'], array());
$obj->type = $dict['type']; $obj->type = $dict['type'];
$obj->fileType = $dict['fileType']; $obj->fileType = $dict['fileType'];
$obj->commitHash = $dict['commitHash']; $obj->commitHash = $dict['commitHash'];