revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-25 16:22:42 +01:00
Code Issues Releases Wiki Activity

Explicitly draw progress bar when resuming file uploads in arc upload

Browse source 
Summary: Ref T7149. Make sure we sit at "Resuming: 60%" or whatever while uploading the first chunk.

Test Plan: Ran `arc upload` on a large file, cancelled it, resumed it, got sensible progress bar.

Reviewers: chad, btrahan

Reviewed By: chad, btrahan

Subscribers: epriestley

Maniphest Tasks: T7149

Differential Revision: https://secure.phabricator.com/D12082
This commit is contained in:
epriestley 2015-03-15 11:31:56 -07:00
parent 856cbed527
commit b961869eda
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/workflow/ArcanistUploadWorkflow.php
View file

@ -190,6 +190,8 @@ EOTEXT
$progress->update(1); $progress->update(1);
} }
$progress->draw();
// TODO: We could do these in parallel to improve upload performance. // TODO: We could do these in parallel to improve upload performance.
foreach ($remaining as $chunk) { foreach ($remaining as $chunk) {
$offset = $chunk['byteStart']; $offset = $chunk['byteStart'];