revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-12-23 05:50:54 +01:00
Code Issues Releases Wiki Activity

Ignore errors from "svn upgrade" in unit tests

Browse source 
Summary: See discussion in D6893. Different versions of `svn` do different stuff, just ignore any possible error here.

Test Plan: Ran unit tests.

Reviewers: andrewjcg, btrahan

Reviewed By: andrewjcg

CC: aran

Differential Revision: https://secure.phabricator.com/D6946
This commit is contained in:
epriestley 2013-09-11 21:23:30 -07:00
parent 1fa8e861b2
commit ba3c8e3356
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/repository/api/__tests__/ArcanistRepositoryAPIStateTestCase.php
View file

@ -40,7 +40,12 @@ final class ArcanistRepositoryAPIStateTestCase extends ArcanistTestCase {
if ($api instanceof ArcanistSubversionAPI) { if ($api instanceof ArcanistSubversionAPI) {
// Upgrade the repository so that the test will still pass if the local // Upgrade the repository so that the test will still pass if the local
// `svn` is newer than the `svn` which created the repository. // `svn` is newer than the `svn` which created the repository.
$api->execxLocal('upgrade');
// NOTE: Some versions of Subversion (1.7.x?) exit with an error code on
// a no-op upgrade, although newer versions do not. We just ignore the
// error here; if it's because of an actual problem we'll hit an error
// shortly anyway.
$api->execManualLocal('upgrade');
} }
$this->assertCorrectState($test, $api); $this->assertCorrectState($test, $api);