revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-29 10:12:41 +01:00
Code Issues Releases Wiki Activity

arc set-config: warn about unknown keys

Browse source 
Summary: See T12266. Warn when the user tries to set a value we will probably not read.

Test Plan: `arc set-config foo bar`, see fancy warning.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D17357
This commit is contained in:
Aviv Eyal 2017-02-15 13:38:57 +00:00 committed by avivey
parent f3037bf216
commit bc9b70508e
1 changed files with 14 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
src/workflow/ArcanistSetConfigWorkflow.php
View file

@ -69,6 +69,16 @@ EOTEXT
$settings = new ArcanistSettings(); $settings = new ArcanistSettings();
$console = PhutilConsole::getConsole();
if (!$settings->getHelp($key)) {
$warn = pht(
'The configuration key \'%s\' is not recognized by arc. It may '.
'be misspelled or out of date.',
$key);
$console->writeErr("**%s:** %s\n", pht('Warning'), $warn);
}
$old = null; $old = null;
if (array_key_exists($key, $config)) { if (array_key_exists($key, $config)) {
$old = $config[$key]; $old = $config[$key];
@ -85,12 +95,12 @@ EOTEXT
$old = $settings->formatConfigValueForDisplay($key, $old); $old = $settings->formatConfigValueForDisplay($key, $old);
if ($old === null) { if ($old === null) {
echo pht( $console->writeOut(
"Deleted key '%s' from %s config.\n", "Deleted key '%s' from %s config.\n",
$key, $key,
$which); $which);
} else { } else {
echo pht( $console->writeOut(
"Deleted key '%s' from %s config (was %s).\n", "Deleted key '%s' from %s config (was %s).\n",
$key, $key,
$which, $which,
@ -110,13 +120,13 @@ EOTEXT
$old = $settings->formatConfigValueForDisplay($key, $old); $old = $settings->formatConfigValueForDisplay($key, $old);
if ($old === null) { if ($old === null) {
echo pht( $console->writeOut(
"Set key '%s' = %s in %s config.\n", "Set key '%s' = %s in %s config.\n",
$key, $key,
$val, $val,
$which); $which);
} else { } else {
echo pht( $console->writeOut(
"Set key '%s' = %s in %s config (was %s).\n", "Set key '%s' = %s in %s config (was %s).\n",
$key, $key,
$val, $val,