revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-25 16:22:42 +01:00
Code Issues Releases Wiki Activity

Remove accidental sprintf injection in error reporting

Browse source 
Summary:
STDERR output with `%`s in it could cause:

```
ERROR 2: fprintf(): Too few arguments at [/usr/local/arcanist/src/workflow/ArcanistFeatureWorkflow.php:170]
```

Test Plan: Untested.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D19261
This commit is contained in:
Alex Vandiver 2018-03-26 10:36:04 -07:00
parent dcd7ef66d0
commit bf3d32e34e
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/workflow/ArcanistFeatureWorkflow.php
View file

@ -167,7 +167,7 @@ EOTEXT
} }
echo $stdout; echo $stdout;
fprintf(STDERR, $stderr); fprintf(STDERR, '%s', $stderr);
return $err; return $err;
} }