From c0c78c2ff4068d927caa5d3d36939957671695b7 Mon Sep 17 00:00:00 2001 From: epriestley Date: Fri, 10 Aug 2012 15:29:27 -0700 Subject: [PATCH] Raise exception instead of returning magical number from 'arc anoid' Summary: how do I python Test Plan: help Reviewers: alanh Reviewed By: alanh CC: aran Differential Revision: https://secure.phabricator.com/D3245 --- scripts/breakout.py | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/scripts/breakout.py b/scripts/breakout.py index 4fabe35a..c7b0e947 100755 --- a/scripts/breakout.py +++ b/scripts/breakout.py @@ -128,6 +128,9 @@ class Ship: win.addch(curses.ACS_RTEE) return True +class PowerOverwhelmingException(Exception): + pass + def main(stdscr): global height, width, ship @@ -139,7 +142,10 @@ def main(stdscr): height, width = stdscr.getmaxyx() if height < 15 or width < 30: - return 1 + raise PowerOverwhelmingException( + "Your computer is not powerful enough to run 'arc anoid'. " + "It must support at least 30 columns and 15 rows of next-gen " + "full-color 3D graphics.") status = curses.newwin(1, width, 0, 0) height -= 1 @@ -202,11 +208,9 @@ def main(stdscr): status.refresh() time.sleep(0.05) -res = curses.wrapper(main) -if res == 1: - print ("Your computer is not powerful enough to run 'arc anoid'. " - "It must support at least 30 columns and 15 rows of next-gen " - "full-color 3D graphics.") -else: +try: + curses.wrapper(main) print ('You destroyed %s blocks out of %s with %s deaths.' % (Block.killed, Block.total, Ball.killed)) +except PowerOverwhelmingException as e: + print e