From c11b9e1af9d04d20a9087287737a26848694d7c8 Mon Sep 17 00:00:00 2001 From: Eric Stern Date: Mon, 12 Aug 2013 13:47:33 -0700 Subject: [PATCH] Fix 'arc lint --everything' when svn has uncommitted changes Summary: My recent change adding --everything to arc lint could sometimes cause a "diff is empty" error, this patch fixes it. Test Plan: Ran "arc lint --everything" before and after patch. No longer errors out. Only appeared to originally happen when there were uncommited changes in an svn repo. Reviewers: epriestley Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6732 --- src/workflow/ArcanistLintWorkflow.php | 1 + 1 file changed, 1 insertion(+) diff --git a/src/workflow/ArcanistLintWorkflow.php b/src/workflow/ArcanistLintWorkflow.php index fb94a699..45505f68 100644 --- a/src/workflow/ArcanistLintWorkflow.php +++ b/src/workflow/ArcanistLintWorkflow.php @@ -222,6 +222,7 @@ EOTEXT $paths = id(new FileFinder($working_copy->getProjectRoot())) ->excludePath($filter) ->find(); + $this->shouldLintAll = true; } else { $paths = $this->selectPathsForWorkflow($paths, $rev); }