mirror of
https://we.phorge.it/source/arcanist.git
synced 2024-11-09 16:32:39 +01:00
Explicitly check for cURL in "arc"
Summary: We do this in Windows, but it's not available by default in Ubuntu Test Plan: Ran "arc" after faking the function name, got a reasonable error. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D2404
This commit is contained in:
parent
b2dc11940f
commit
c3a4049950
1 changed files with 11 additions and 1 deletions
|
@ -332,7 +332,12 @@ function sanity_check_environment() {
|
|||
);
|
||||
} else {
|
||||
$need_functions = array(
|
||||
'json_decode' => array('flag', '--without-json'),
|
||||
'curl_init' => array(
|
||||
'text',
|
||||
"You need to install the cURL PHP extension, maybe with ".
|
||||
"'apt-get install php5-curl' or 'yum install php53-curl' or ".
|
||||
"something similar."),
|
||||
'json_decode' => array('flag', '--without-json'),
|
||||
);
|
||||
}
|
||||
|
||||
|
@ -378,6 +383,11 @@ function sanity_check_environment() {
|
|||
"'extension={$which}'.";
|
||||
}
|
||||
|
||||
if ($what == 'text') {
|
||||
$generic = false;
|
||||
$problems[] = $which;
|
||||
}
|
||||
|
||||
if ($generic) {
|
||||
$problems[] =
|
||||
"This build of PHP is missing the required function '{$fname}()'. ".
|
||||
|
|
Loading…
Reference in a new issue