revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-26 08:42:40 +01:00
Code Issues Releases Wiki Activity

It should be also valid to have empty change under hg

Browse source 
Summary: Like git, it is also valid to have empty net change under hg. Should not throw if that is the case.

Test Plan: Tried on a hg repo.

Reviewers: lifeihuang, #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D8888
This commit is contained in:
Peng Li 2014-04-29 14:17:35 -07:00 committed by epriestley
parent 0df22a97a1
commit c4ec22b140
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/workflow/ArcanistBaseWorkflow.php
View file

@ -1124,10 +1124,10 @@ abstract class ArcanistBaseWorkflow extends Phobject {
} }
if (empty($this->changeCache[$path])) { if (empty($this->changeCache[$path])) {
if ($is_git) { if ($is_git || $is_hg) {
// This can legitimately occur under git if you make a change, "git // This can legitimately occur under git/hg if you make a change,
// commit" it, and then revert the change in the working copy and run // "git/hg commit" it, and then revert the change in the working copy
// "arc lint". // and run "arc lint".
$change = new ArcanistDiffChange(); $change = new ArcanistDiffChange();
$change->setCurrentPath($path); $change->setCurrentPath($path);
return $change; return $change;