revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-12-01 19:22:41 +01:00
Code Issues Releases Wiki Activity

Add missing newline in arc export

Browse source 
Summary:
Hunk may be missing newline at end of file. It produces exports like this:

  lang=diff
  --- a/third-party
  +++ b/third-party
  @@ -1 +1 @@
  -/mnt/gvfs/third-party/90cb1654197e56261b1733c704b387285f36208e
  \ No newline at end of file
  +/mnt/gvfs/third-party/7097083d10d37251218531da398545658872a47a
  \ No newline at end of filediff --git a/ti/proxygen/TARGETS b/ti/proxygen/TARGETS

Test Plan:
  $ arc export --git --diff 1

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin, lesliepc16

Differential Revision: https://secure.phabricator.com/D3672
This commit is contained in:
vrana 2012-10-09 17:11:41 -07:00
parent 35f20154ae
commit c57ee8e564
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/parser/ArcanistBundle.php
View file

@ -600,6 +600,11 @@ final class ArcanistBundle {
$result[] = "@@ -{$o_head} +{$n_head} @@".PHP_EOL; $result[] = "@@ -{$o_head} +{$n_head} @@".PHP_EOL;
$result[] = $corpus; $result[] = $corpus;
$last = substr($corpus, -1);
if ($last !== false && $last != "\r" && $last != "\n") {
$result[] = PHP_EOL;
}
} }
} }
return implode('', $result); return implode('', $result);