revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-26 08:42:40 +01:00
Code Issues Releases Wiki Activity

Prefer pip to easy_install

Browse source 
Summary:
Prefer pip to easy_install
also fixes incorrect install instructions for closure linters

Fixes T10892
Ref T10038

Test Plan: inspection

Reviewers: avivey, #blessed_reviewers, epriestley, tjstum

Reviewed By: avivey, #blessed_reviewers, epriestley, tjstum

Subscribers: avivey, Korvin

Maniphest Tasks: T10038, T10892

Differential Revision: https://secure.phabricator.com/D15818
This commit is contained in:
Eitan Adler 2016-04-29 15:45:11 +00:00 committed by eadler
parent 768e1a56bc
commit c58f1b9a25
3 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/lint/linter/ArcanistClosureLinter.php
View file

@ -33,8 +33,7 @@ final class ArcanistClosureLinter extends ArcanistExternalLinter {
return pht( return pht(
'Install %s using `%s`.', 'Install %s using `%s`.',
'gjslint', 'gjslint',
'sudo easy_install http://closure-linter.googlecode.com/'. 'pip install closure-linter');
'files/closure_linter-latest.tar.gz');
} }
protected function parseLinterOutput($path, $err, $stdout, $stderr) { protected function parseLinterOutput($path, $err, $stdout, $stderr) {

2
src/lint/linter/ArcanistFlake8Linter.php
View file

@ -45,7 +45,7 @@ final class ArcanistFlake8Linter extends ArcanistExternalLinter {
} }
public function getInstallInstructions() { public function getInstallInstructions() {
return pht('Install flake8 using `%s`.', 'easy_install flake8'); return pht('Install flake8 using `%s`.', 'pip install flake8');
} }
protected function parseLinterOutput($path, $err, $stdout, $stderr) { protected function parseLinterOutput($path, $err, $stdout, $stderr) {

2
src/lint/linter/ArcanistPEP8Linter.php
View file

@ -43,7 +43,7 @@ final class ArcanistPEP8Linter extends ArcanistExternalLinter {
} }
public function getInstallInstructions() { public function getInstallInstructions() {
return pht('Install PEP8 using `%s`.', 'easy_install pep8'); return pht('Install PEP8 using `%s`.', 'pip install pep8');
} }
protected function parseLinterOutput($path, $err, $stdout, $stderr) { protected function parseLinterOutput($path, $err, $stdout, $stderr) {