From c727a98f7340e1059ccebdf69a02bdada353fba4 Mon Sep 17 00:00:00 2001 From: Joshua Spence Date: Tue, 24 Jun 2014 04:49:09 +1000 Subject: [PATCH] Add a URL to support a TODO comment. Summary: Provide a link to a "resolved" [[http://bugs.xdebug.org/view.php?id=1041 | Xdebug issue]] to support a TODO comment. Further information can be found at http://derickrethans.nl/dead-code.html. Test Plan: Read the article. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9696 --- src/unit/engine/phutil/ArcanistPhutilTestCase.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/unit/engine/phutil/ArcanistPhutilTestCase.php b/src/unit/engine/phutil/ArcanistPhutilTestCase.php index 291cdcbc..761323f6 100644 --- a/src/unit/engine/phutil/ArcanistPhutilTestCase.php +++ b/src/unit/engine/phutil/ArcanistPhutilTestCase.php @@ -576,6 +576,8 @@ abstract class ArcanistPhutilTestCase { // TODO: This indicates "unreachable", but it flags the closing braces // of functions which end in "return", which is super ridiculous. Just // ignore it for now. + // + // See http://bugs.xdebug.org/view.php?id=1041 $str .= 'N'; // Not executable. } else if ($c === 1) { $str .= 'C'; // Covered.