revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-29 02:02:40 +01:00
Code Issues Releases Wiki Activity

Add a URL to support a TODO comment.

Browse source 
Summary: Provide a link to a "resolved" [[http://bugs.xdebug.org/view.php?id=1041 | Xdebug issue]] to support a TODO comment. Further information can be found at http://derickrethans.nl/dead-code.html.

Test Plan: Read the article.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D9696
This commit is contained in:
Joshua Spence 2014-06-24 04:49:09 +10:00
parent 213628ff34
commit c727a98f73
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/unit/engine/phutil/ArcanistPhutilTestCase.php
View file

@ -576,6 +576,8 @@ abstract class ArcanistPhutilTestCase {
// TODO: This indicates "unreachable", but it flags the closing braces // TODO: This indicates "unreachable", but it flags the closing braces
// of functions which end in "return", which is super ridiculous. Just // of functions which end in "return", which is super ridiculous. Just
// ignore it for now. // ignore it for now.
//
// See http://bugs.xdebug.org/view.php?id=1041
$str .= 'N'; // Not executable. $str .= 'N'; // Not executable.
} else if ($c === 1) { } else if ($c === 1) {
$str .= 'C'; // Covered. $str .= 'C'; // Covered.