From c804c5026011f27614a7bbdb2bb32cab590d68ca Mon Sep 17 00:00:00 2001 From: Alex Vandiver Date: Wed, 20 Sep 2017 14:09:04 -0700 Subject: [PATCH] Don't show a blank line if there is no user data Summary: SKIP lines, for instance, often have no UserData; there is no reason to display a content-less blank line. Test Plan: `arc unit` Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D18632 --- src/unit/renderer/ArcanistUnitConsoleRenderer.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/unit/renderer/ArcanistUnitConsoleRenderer.php b/src/unit/renderer/ArcanistUnitConsoleRenderer.php index fa646fc5..6294cdee 100644 --- a/src/unit/renderer/ArcanistUnitConsoleRenderer.php +++ b/src/unit/renderer/ArcanistUnitConsoleRenderer.php @@ -21,7 +21,8 @@ final class ArcanistUnitConsoleRenderer extends ArcanistUnitRenderer { $this->getFormattedResult($result->getResult()).$duration, $test_name); - if ($result_code != ArcanistUnitTestResult::RESULT_PASS) { + if ($result_code != ArcanistUnitTestResult::RESULT_PASS + && strlen($result->getUserData())) { $return .= $result->getUserData()."\n"; }