(stable) Promote 2016 Week 32

.arcconfig

@@ -2,5 +2,6 @@
   "phabricator.uri": "https://secure.phabricator.com/",
   "load": [
     "src/"
-  ]
+  ],
+  "history.immutable": false
 }

src/land/ArcanistGitLandEngine.php

@@ -181,7 +181,10 @@ final class ArcanistGitLandEngine
           $this->getTargetFullRef()));
     }
 
-    list($changes) = $api->execxLocal('diff HEAD --');
+    // TODO: This could probably be cleaner by asking the API a question
+    // about working copy status instead of running a raw diff command. See
+    // discussion in T11435.
+    list($changes) = $api->execxLocal('diff --no-ext-diff HEAD --');
     $changes = trim($changes);
     if (!strlen($changes)) {
       throw new Exception(

src/lint/linter/xhpast/rules/ArcanistPHPCompatibilityXHPASTLinterRule.php

@@ -369,6 +369,19 @@ final class ArcanistPHPCompatibilityXHPASTLinterRule
       }
     }
 
+    $literals = $root->selectDescendantsOftype('n_ARRAY_LITERAL');
+    foreach ($literals as $literal) {
+      $open_token = head($literal->getTokens())->getValue();
+      if ($open_token == '[') {
+        $this->raiseLintAtNode(
+          $literal,
+          pht(
+            'The short array syntax ("[...]") was not introduced until '.
+            'PHP 5.4, but this codebase targets an earlier version of PHP. '.
+            'You can rewrite this expression using `array(...)` instead.'));
+      }
+    }
+
     $closures = $this->getAnonymousClosures($root);
     foreach ($closures as $closure) {
       $static_accesses = $closure

src/lint/linter/xhpast/rules/__tests__/php-compatibility/php54-features.lint-test

@@ -22,12 +22,15 @@ final class SomeClass extends Phobject {
 
 0b1;
 
+[];
+
 ~~~~~~~~~~
 error:3:5
 error:4:9
 error:12:7
 error:18:7
 error:23:1
+error:25:1
 ~~~~~~~~~~
 ~~~~~~~~~~
 {