1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-12-22 05:20:55 +01:00

Enable unit tests for ArcanistJscsLinterTestCase

Summary:
https://github.com/mdevils/node-jscs/issues/444 has been resolved in commit [[0de667bac2 | 0de667bac2491ba04d930ff94e990965213ba36b]], which means that `jscs` can be easily run on files with any extension.

NOTE: JSCS version 1.5.7 is required.

Test Plan: `arc unit`

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D9789
This commit is contained in:
Joshua Spence 2014-07-03 05:15:09 +10:00
parent aaf626fc39
commit ca5f05e62b
2 changed files with 2 additions and 8 deletions

View file

@ -3,12 +3,6 @@
final class ArcanistJscsLinterTestCase extends ArcanistArcanistLinterTestCase {
public function testJscsLinter() {
// NOTE: JSCS will only lint files with a `*.js` extension.
//
// See https://github.com/mdevils/node-jscs/issues/444
$this->assertTrue(true);
return;
$this->executeTestsInDirectory(
dirname(__FILE__).'/jscs/',
new ArcanistJscsLinter());

View file

@ -1,8 +1,8 @@
function foo() {
if (true) return 'foo'; else return 'bar';
if (true) return "foo"; else return "bar";
}
~~~~~~~~~~
error:2:
error:2:3
~~~~~~~~~~
~~~~~~~~~~
{