revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-22 06:42:41 +01:00
Code Issues Releases Wiki Activity

Fix idx default empty string in ArcanistWorkflow

Browse source 
Summary:
Another fix for PHP 8.1 deprecations.

Closes T15259
Ref T15190

Test Plan: Run arc patch with certificate uninstalled

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15259, T15190

Differential Revision: https://we.phorge.it/D25128
This commit is contained in:
rgodden 2023-04-19 18:07:58 +01:00
parent 75af13abe9
commit ca5f5cd152
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/workflow/ArcanistWorkflow.php
View file

@ -479,7 +479,7 @@ abstract class ArcanistWorkflow extends Phobject {
// If we have `token`, this server supports the simpler, new-style // If we have `token`, this server supports the simpler, new-style
// token-based authentication. Use that instead of all the certificate // token-based authentication. Use that instead of all the certificate
// stuff. // stuff.
$token = idx($credentials, 'token'); $token = idx($credentials, 'token', '');
if (strlen($token)) { if (strlen($token)) {
$conduit = $this->getConduit(); $conduit = $this->getConduit();
@ -2244,7 +2244,7 @@ abstract class ArcanistWorkflow extends Phobject {
protected function getModernUnitDictionary(array $map) { protected function getModernUnitDictionary(array $map) {
$map = $this->getModernCommonDictionary($map); $map = $this->getModernCommonDictionary($map);
$details = idx($map, 'userData'); $details = idx($map, 'userData', '');
if (strlen($details)) { if (strlen($details)) {
$map['details'] = (string)$details; $map['details'] = (string)$details;
} }