revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-29 10:12:41 +01:00
Code Issues Releases Wiki Activity

Warn about strstr() misuse

Browse source 
Summary: See D3296#1.

Test Plan:
New test.
Linted Arcanist, libphutil, Phabricator repositories, found no false positive and one real positive.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D3297
This commit is contained in:
vrana 2012-08-15 13:30:40 -07:00
parent 34efe49e12
commit cae7631dff
2 changed files with 47 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

43
src/lint/linter/ArcanistXHPASTLinter.php
View file

@ -221,6 +221,49 @@ final class ArcanistXHPASTLinter extends ArcanistLinter {
$this->lintPHP54Features($root); $this->lintPHP54Features($root);
$this->lintPHT($root); $this->lintPHT($root);
$this->lintStrposUsedForStart($root); $this->lintStrposUsedForStart($root);
$this->lintStrstrUsedForCheck($root);
}
public function lintStrstrUsedForCheck($root) {
$expressions = $root->selectDescendantsOfType('n_BINARY_EXPRESSION');
foreach ($expressions as $expression) {
$operator = $expression->getChildOfType(1, 'n_OPERATOR');
$operator = $operator->getConcreteString();
if ($operator != '===' && $operator != '!==') {
continue;
}
$false = $expression->getChildByIndex(0);
if ($false->getTypeName() == 'n_SYMBOL_NAME' &&
$false->getConcreteString() == 'false') {
$strstr = $expression->getChildByIndex(2);
} else {
$strstr = $false;
$false = $expression->getChildByIndex(2);
if ($false->getTypeName() != 'n_SYMBOL_NAME' ||
$false->getConcreteString() != 'false') {
continue;
}
}
if ($strstr->getTypeName() != 'n_FUNCTION_CALL') {
continue;
}
$name = strtolower($strstr->getChildByIndex(0)->getConcreteString());
if ($name == 'strstr' || $name == 'strchr') {
$this->raiseLintAtNode(
$strstr,
self::LINT_SLOWNESS,
"Use strpos() for checking if the string contains something.");
} else if ($name == 'stristr') {
$this->raiseLintAtNode(
$strstr,
self::LINT_SLOWNESS,
"Use stripos() for checking if the string contains something.");
}
}
} }
public function lintStrposUsedForStart($root) { public function lintStrposUsedForStart($root) {

4
src/lint/linter/__tests__/xhpast/slowness.lint-test
View file

@ -4,7 +4,11 @@
(strpos('a', 'b') !== 0); (strpos('a', 'b') !== 0);
(0 === strpos('a', 'b')); (0 === strpos('a', 'b'));
(1 + 0 === strpos('a', 'b')); (1 + 0 === strpos('a', 'b'));
(strstr('a', 'b') === false);
(strstr('a', 'b') === 'b');
~~~~~~~~~~ ~~~~~~~~~~
warning:3:2 warning:3:2
warning:4:2 warning:4:2
warning:5:8 warning:5:8
warning:8:2