revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-09 00:12:40 +01:00
Code Issues Releases Wiki Activity

Remove "arc diff --plan-changes"

Browse source 
Summary: Experimental branch. Ref T2543. To be replaced with "arc diff --draft". Depends on D18737.

Test Plan: Grepped for `plan-changes`.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T2543

Differential Revision: https://secure.phabricator.com/D18738
This commit is contained in:
epriestley 2017-10-27 09:14:05 -07:00
parent 856f79bba5
commit ccd648b4c4
1 changed files with 0 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
src/workflow/ArcanistDiffWorkflow.php
View file

@ -233,14 +233,6 @@ EOTEXT
'message' => pht('%s does not update any revision.', '--preview'),
),
),
'plan-changes' => array(
'help' => pht(
'Create or update a revision without requesting a code review.'),
'conflicts' => array(
'only' => pht('%s does not affect revisions.', '--only'),
'preview' => pht('%s does not affect revisions.', '--preview'),
),
),
'encoding' => array(
'param' => 'encoding',
'help' => pht(
@ -592,16 +584,6 @@ EOTEXT
pht('Revision URI:'),
$uri);
if ($this->getArgument('plan-changes')) {
$conduit->callMethodSynchronous(
'differential.createcomment',
array(
'revision_id' => $result['revisionid'],
'action' => 'rethink',
));
echo pht('Planned changes to the revision.')."\n";
}
if ($this->shouldOpenCreatedObjectsInBrowser()) {
$this->openURIsInBrowser(array($uri));
}