revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-22 06:42:41 +01:00
Code Issues Releases Wiki Activity

Fix an issue where "phutil_utf8v()" could fatal when passed an integer

Browse source 
Summary:
See <https://discourse.phabricator-community.org/t/search-by-name-in-files-doesnt-support-number/4300>.

I can't exactly reproduce the original issue, but when a query like "quack 1234" is tokenized, we end up calling "phutil_utf8v(1234)", where the argument is an integer.

At least in recent versions of PHP, this fatals ("trying to access an offset of an integer"). Cast the argument first.

Test Plan: Searched for "quack 1234" in Files. Before: fatal accessing offset of integer; after: correct results.

Differential Revision: https://secure.phabricator.com/D21477
This commit is contained in:
epriestley 2020-10-16 09:18:50 -07:00
parent 04e340ab0f
commit ccf74a40dd
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/utils/utf8.php
View file

@ -426,6 +426,8 @@ function phutil_utf8_is_cjk($string) {
* @return list A list of characters in the string. * @return list A list of characters in the string.
*/ */
function phutil_utf8v($string, $byte_limit = null) { function phutil_utf8v($string, $byte_limit = null) {
$string = phutil_string_cast($string);
$res = array(); $res = array();
$len = strlen($string); $len = strlen($string);