From cd591318ca65c6bd041bb7e35c9092b90c167f13 Mon Sep 17 00:00:00 2001 From: Joshua Spence Date: Wed, 7 Jan 2015 07:35:20 +1100 Subject: [PATCH] Fix visibility of the `ArcanistLintEngine::buildLinters()` method Summary: Ref T6822. This method needs to be public so that it can be called from `ArcanistLintersWorkflow`. Test Plan: Ran `arc linters`. Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6822 Differential Revision: https://secure.phabricator.com/D11239 --- src/lint/engine/ArcanistLintEngine.php | 2 +- src/lint/engine/ArcanistUnitTestableLintEngine.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lint/engine/ArcanistLintEngine.php b/src/lint/engine/ArcanistLintEngine.php index ffe54cab..b88d29b8 100644 --- a/src/lint/engine/ArcanistLintEngine.php +++ b/src/lint/engine/ArcanistLintEngine.php @@ -417,7 +417,7 @@ abstract class ArcanistLintEngine { return $this->stopped; } - abstract protected function buildLinters(); + abstract public function buildLinters(); final protected function didRunLinters(array $linters) { assert_instances_of($linters, 'ArcanistLinter'); diff --git a/src/lint/engine/ArcanistUnitTestableLintEngine.php b/src/lint/engine/ArcanistUnitTestableLintEngine.php index 278e3188..af30a104 100644 --- a/src/lint/engine/ArcanistUnitTestableLintEngine.php +++ b/src/lint/engine/ArcanistUnitTestableLintEngine.php @@ -25,7 +25,7 @@ final class ArcanistUnitTestableLintEngine extends ArcanistLintEngine { return parent::pathExists($path); } - protected function buildLinters() { + public function buildLinters() { return $this->linters; }