Pass --error-level=all to puppet-lint

Summary: Without explicitly passing `--error-level=all` to `puppet-lint`, the configuration file for `puppet-lint` could contain `--error-level=error`. This would limit the ability of `arc lint` to detect linter issues and therefore we should override this flag from the command line explicitly.

Test Plan: This is mostly theoretical.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D11316

src/lint/linter/ArcanistPuppetLintLinter.php

@@ -58,12 +58,14 @@ final class ArcanistPuppetLintLinter extends ArcanistExternalLinter {
   }
 
   protected function getMandatoryFlags() {
-    return array(sprintf('--log-format=%s', implode('|', array(
+    return array(
-      '%{linenumber}',
+      '--error-level=all',
-      '%{column}',
+      sprintf('--log-format=%s', implode('|', array(
-      '%{kind}',
+        '%{linenumber}',
-      '%{check}',
+        '%{column}',
-      '%{message}',
+        '%{kind}',
+        '%{check}',
+        '%{message}',
       ))),
     );
   }