From cf76d2fc1c5084c8971407afd6c22d59a6a8cdb1 Mon Sep 17 00:00:00 2001 From: Shayne Sweeney Date: Tue, 9 Apr 2013 15:06:55 -0700 Subject: [PATCH] Add py/pl files to $text_paths (remove l/y files?!) Summary: I'm guessing this was refactored somewhere down the line and it meant that Python and Perl files were no longer considered text files. I'm imagining the old regex was: p(hp|y|l). Therefore I blame CSS. Test Plan: Perform an arc lint on a Python or Perl file that has trailing whitespace on a line. It should prompt you for an autocorrecting lint. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5637 --- src/lint/engine/ComprehensiveLintEngine.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lint/engine/ComprehensiveLintEngine.php b/src/lint/engine/ComprehensiveLintEngine.php index b0f2c20f..e8a104d2 100644 --- a/src/lint/engine/ComprehensiveLintEngine.php +++ b/src/lint/engine/ComprehensiveLintEngine.php @@ -23,7 +23,7 @@ final class ComprehensiveLintEngine extends ArcanistLintEngine { } } - $text_paths = preg_grep('/\.(php|css|hpp|cpp|l|y)$/', $paths); + $text_paths = preg_grep('/\.(php|css|hpp|cpp|l|y|py|pl)$/', $paths); $linters[] = id(new ArcanistGeneratedLinter())->setPaths($text_paths); $linters[] = id(new ArcanistNoLintLinter())->setPaths($text_paths); $linters[] = id(new ArcanistTextLinter())->setPaths($text_paths);