Remove @group annotations

Summary: I'm pretty sure that `@group` annotations are useless now... I believe that they were originally used by Diviner?

Test Plan: Eye-balled it.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: epriestley, Korvin, aurelijus

Differential Revision: https://secure.phabricator.com/D9855

scripts/__init_script__.php

@@ -11,7 +11,6 @@
  * When looking in these places, we expect to find a 'libphutil/' directory.
  */
 function arcanist_adjust_php_include_path() {
-
   // The 'arcanist/' directory.
   $arcanist_dir = dirname(dirname(__FILE__));
 

src/configuration/ArcanistConfiguration.php

@@ -17,7 +17,6 @@
  *    - add new flags to existing workflows by overriding
  *      getCustomArgumentsForCommand().
  *
- * @group config
  * @concrete-extensible
  */
 class ArcanistConfiguration {
@@ -65,8 +64,11 @@ class ArcanistConfiguration {
     // This is a hook.
   }
 
-  public function didRunWorkflow($command, ArcanistBaseWorkflow $workflow,
+  public function didRunWorkflow(
+    $command,
+    ArcanistBaseWorkflow $workflow,
     $err) {
+
     // This is a hook.
   }
 

src/configuration/ArcanistConfigurationManager.php

@@ -2,8 +2,6 @@
 
 /**
  * This class holds everything related to configuration and configuration files.
- *
- * @group config
  */
 final class ArcanistConfigurationManager {
 

src/configuration/ArcanistSettings.php

@@ -1,8 +1,5 @@
 <?php
 
-/**
- * @group config
- */
 final class ArcanistSettings {
 
   private function getOptions() {
@@ -329,5 +326,4 @@ final class ArcanistSettings {
     return $value;
   }
 
-
 }

src/configuration/__tests__/ArcanistBritishTestCase.php

@@ -56,7 +56,6 @@ final class ArcanistBritishTestCase extends ArcanistTestCase {
       "Correction of {$input} against: {$commands}");
   }
 
-
   public function testArgumentCompletion() {
     $this->assertArgumentCompletion(
       array('nolint'),

src/difference/ArcanistDiffUtils.php

@@ -2,8 +2,6 @@
 
 /**
  * Dumping ground for diff- and diff-algorithm-related miscellany.
- *
- * @group diff
  */
 final class ArcanistDiffUtils {
 

src/difference/__tests__/ArcanistDiffUtilsTestCase.php

@@ -2,71 +2,70 @@
 
 /**
  * Test cases for @{class:ArcanistDiffUtils}.
- *
- * @group testcase
  */
 final class ArcanistDiffUtilsTestCase extends ArcanistTestCase {
+
   public function testLevenshtein() {
     $tests = array(
       array(
         'a',
         'b',
-        'x'
+        'x',
       ),
       array(
         'kalrmr(array($b))',
         'array($b)',
-        'dddddddssssssssds'
+        'dddddddssssssssds',
       ),
       array(
         'array($b)',
         'kalrmr(array($b))',
-        'iiiiiiissssssssis'
+        'iiiiiiissssssssis',
       ),
       array(
         'zkalrmr(array($b))z',
         'xarray($b)x',
-        'dddddddxsssssssssdx'
+        'dddddddxsssssssssdx',
       ),
       array(
         'xarray($b)x',
         'zkalrmr(array($b))z',
-        'iiiiiiixsssssssssix'
+        'iiiiiiixsssssssssix',
       ),
       array(
         'abcdefghi',
         'abcdefghi',
-        'sssssssss'
+        'sssssssss',
       ),
       array(
         'abcdefghi',
         'abcdefghijkl',
-        'sssssssssiii'
+        'sssssssssiii',
       ),
       array(
         'abcdefghijkl',
         'abcdefghi',
-        'sssssssssddd'
+        'sssssssssddd',
       ),
       array(
         'xyzabcdefghi',
         'abcdefghi',
-        'dddsssssssss'
+        'dddsssssssss',
       ),
       array(
         'abcdefghi',
         'xyzabcdefghi',
-        'iiisssssssss'
+        'iiisssssssss',
       ),
       array(
         'abcdefg',
         'abxdxfg',
-        'ssxsxss'
+        'ssxsxss',
       ),
       array(
         'private function a($a, $b) {',
         'public function and($b, $c) {',
-        'siixsdddxsssssssssssiissxsssxsss'
+        'siixsdddxsssssssssssiissxsssxsss',
       ),
       array(
 
@@ -122,7 +121,7 @@ final class ArcanistDiffUtilsTestCase extends ArcanistTestCase {
     $right = '';
     $result = array(
       array(array(0, 0)),
-                array(array(0, 0))
+      array(array(0, 0)),
     );
     $this->assertEqual(
       $result,
@@ -133,7 +132,7 @@ final class ArcanistDiffUtilsTestCase extends ArcanistTestCase {
     $right = "Grumpy\xE2\x98\x83at";
     $result = array(
       array(array(0, 0)),
-                array(array(0, 11))
+      array(array(0, 11)),
     );
     $this->assertEqual(
       $result,
@@ -144,7 +143,7 @@ final class ArcanistDiffUtilsTestCase extends ArcanistTestCase {
     $right = '';
     $result = array(
       array(array(0, 11)),
-                array(array(0, 0))
+      array(array(0, 0)),
     );
     $this->assertEqual(
       $result,
@@ -155,7 +154,7 @@ final class ArcanistDiffUtilsTestCase extends ArcanistTestCase {
     $right = "Grumpy\xE2\x98\x83at";
     $result = array(
       array(array(0, 11)),
-                array(array(0, 11))
+      array(array(0, 11)),
     );
     $this->assertEqual(
       $result,
@@ -166,7 +165,7 @@ final class ArcanistDiffUtilsTestCase extends ArcanistTestCase {
     $right = 'Smiling Dog';
     $result = array(
       array(array(1, 11)),
-                array(array(1, 11))
+      array(array(1, 11)),
     );
     $this->assertEqual(
       $result,
@@ -177,7 +176,7 @@ final class ArcanistDiffUtilsTestCase extends ArcanistTestCase {
     $right = "Grumpy\xE2\x98\x83at";
     $result = array(
       array(array(0, 6), array(1, 1), array(0, 2)),
-                array(array(0, 6), array(1, 3), array(0, 2))
+      array(array(0, 6), array(1, 3), array(0, 2)),
     );
     $this->assertEqual(
       $result,
@@ -188,7 +187,7 @@ final class ArcanistDiffUtilsTestCase extends ArcanistTestCase {
     $right = "Grumpy\xE2\x98\x83a\xE2\x98\x83t";
     $result = array(
       array(array(0, 6), array(1, 2), array(0, 1)),
-                array(array(0, 6), array(1, 7), array(0, 1))
+      array(array(0, 6), array(1, 7), array(0, 1)),
     );
     $this->assertEqual(
       $result,
@@ -199,7 +198,7 @@ final class ArcanistDiffUtilsTestCase extends ArcanistTestCase {
     $right = "DrumpyC\xE2\x98\x83t";
     $result = array(
       array(array(1, 1), array(0, 10)),
-                array(array(1, 1), array(0, 10))
+      array(array(1, 1), array(0, 10)),
     );
     $this->assertEqual(
       $result,
@@ -210,7 +209,7 @@ final class ArcanistDiffUtilsTestCase extends ArcanistTestCase {
     $right = "GrumpyC\xE2\x98\x83P";
     $result = array(
       array(array(0, 10), array(1, 1)),
-                array(array(0, 10), array(1, 1))
+      array(array(0, 10), array(1, 1)),
     );
     $this->assertEqual(
       $result,
@@ -221,7 +220,7 @@ final class ArcanistDiffUtilsTestCase extends ArcanistTestCase {
     $right = "DrumpyC\xE2\x98\x83P";
     $result = array(
       array(array(1, 1), array(0, 9), array(1, 1)),
-                array(array(1, 1), array(0, 9), array(1, 1))
+      array(array(1, 1), array(0, 9), array(1, 1)),
     );
     $this->assertEqual(
       $result,
@@ -233,10 +232,11 @@ final class ArcanistDiffUtilsTestCase extends ArcanistTestCase {
     $right = "Sen{$cc}or";
     $result = array(
       array(array(0, 2), array(1, 1), array(0, 2)),
-                array(array(0, 2), array(1, 3), array(0, 2))
+      array(array(0, 2), array(1, 3), array(0, 2)),
     );
     $this->assertEqual(
       $result,
       ArcanistDiffUtils::generateIntralineDiff($left, $right));
   }
+
 }

src/differential/ArcanistDifferentialCommitMessage.php

@@ -2,8 +2,6 @@
 
 /**
  * Represents a parsed commit message.
- *
- * @group differential
  */
 final class ArcanistDifferentialCommitMessage {
 

src/differential/ArcanistDifferentialCommitMessageParserException.php

@@ -2,8 +2,6 @@
 
 /**
  * Thrown when a commit message isn't parseable.
- *
- * @group differential
  */
 final class ArcanistDifferentialCommitMessageParserException extends Exception {
 

src/events/constant/ArcanistEventType.php

@@ -12,4 +12,5 @@ final class ArcanistEventType extends PhutilEventType {
   const TYPE_REVISION_WILLCREATEREVISION = 'revision.willCreateRevision';
 
   const TYPE_LAND_WILLPUSHREVISION  = 'land.willPushRevision';
+
 }

src/exception/ArcanistChooseInvalidRevisionException.php

@@ -2,9 +2,5 @@
 
 /**
  * Thrown when the user chooses an invalid revision when prompted by a workflow.
- *
- * @group workflow
  */
-final class ArcanistChooseInvalidRevisionException extends Exception {
+final class ArcanistChooseInvalidRevisionException extends Exception {}
-
-}

src/exception/ArcanistChooseNoRevisionsException.php

@@ -3,9 +3,5 @@
 /**
  * Thrown when there are no valid revisions to choose from, in a workflow which
  * prompts the user to choose a revision.
- *
- * @group workflow
  */
-final class ArcanistChooseNoRevisionsException extends Exception {
+final class ArcanistChooseNoRevisionsException extends Exception {}
-
-}

src/exception/ArcanistUsageException.php

@@ -4,9 +4,6 @@
  * Thrown when there is a problem with how a user is invoking a command, rather
  * than a technical problem.
  *
- * @group workflow
  * @concrete-extensible
  */
-class ArcanistUsageException extends Exception {
+class ArcanistUsageException extends Exception {}
-
-}

src/exception/usage/ArcanistNoEffectException.php

@@ -3,8 +3,5 @@
 /**
  * Thrown when lint or unit tests have no effect, i.e. no paths are affected
  * by any linter or no unit tests provide coverage.
- *
- * @group workflow
  */
-final class ArcanistNoEffectException extends ArcanistUsageException {
+final class ArcanistNoEffectException extends ArcanistUsageException {}
-}

src/exception/usage/ArcanistNoEngineException.php

@@ -2,8 +2,5 @@
 
 /**
  * Thrown when no engine is configured for linting or running unit tests.
- *
- * @group workflow
  */
-final class ArcanistNoEngineException extends ArcanistUsageException {
+final class ArcanistNoEngineException extends ArcanistUsageException {}
-}

src/exception/usage/ArcanistUserAbortException.php

@@ -3,11 +3,11 @@
 /**
  * Thrown when the user chooses not to continue when warned that they're about
  * to do something dangerous.
- *
- * @group workflow
  */
 final class ArcanistUserAbortException extends ArcanistUsageException {
+
   public function __construct() {
     parent::__construct('User aborted the workflow.');
   }
+
 }

src/hgdaemon/ArcanistHgProxyClient.php

@@ -1,6 +1,5 @@
 <?php
 
-
 /**
  * Client for an @{class:ArcanistHgProxyServer}. This client talks to a PHP
  * process which serves as a proxy in front of a Mercurial server process.

src/hgdaemon/ArcanistHgProxyServer.php

@@ -446,7 +446,6 @@ final class ArcanistHgProxyServer {
   }
 
   private function daemonize() {
-
     // Keep stdout if it's been redirected somewhere, otherwise shut it down.
     $keep_stdout = false;
     $keep_stderr = false;

src/lint/ArcanistLintMessage.php

@@ -2,8 +2,6 @@
 
 /**
  * Message emitted by a linter, like an error or warning.
- *
- * @group lint
  */
 final class ArcanistLintMessage {
 

src/lint/ArcanistLintPatcher.php

@@ -2,8 +2,6 @@
 
 /**
  * Applies lint patches to the working copy.
- *
- * @group lint
  */
 final class ArcanistLintPatcher {
 

src/lint/ArcanistLintResult.php

@@ -2,8 +2,6 @@
 
 /**
  * A group of @{class:ArcanistLintMessage}s that apply to a file.
- *
- * @group lint
  */
 final class ArcanistLintResult {
 
@@ -101,7 +99,6 @@ final class ArcanistLintResult {
 
     $this->effectiveMessages = $messages;
     $this->needsSort = false;
-
   }
 
 }

src/lint/ArcanistLintSeverity.php

@@ -2,8 +2,6 @@
 
 /**
  * Describes the severity of an @{class:ArcanistLintMessage}.
- *
- * @group lint
  */
 final class ArcanistLintSeverity {
 
@@ -34,7 +32,6 @@ final class ArcanistLintSeverity {
   }
 
   public static function isAtLeastAsSevere($message_sev, $level) {
-
     static $map = array(
       self::SEVERITY_DISABLED => 10,
       self::SEVERITY_ADVICE   => 20,
@@ -50,5 +47,4 @@ final class ArcanistLintSeverity {
     return $map[$message_sev] >= idx($map, $level, 0);
   }
 
-
 }

src/lint/engine/ArcanistLintEngine.php

@@ -39,7 +39,6 @@
  * See @{article@phabricator:Arcanist User Guide: Customizing Lint, Unit Tests
  * and Workflows} for more information about configuring lint engines.
  *
- * @group lint
  * @stable
  */
 abstract class ArcanistLintEngine {
@@ -385,8 +384,10 @@ abstract class ArcanistLintEngine {
     return ArcanistLintSeverity::isAtLeastAsSevere($severity, $minimum);
   }
 
-  final private function shouldUseCache($cache_granularity,
+  final private function shouldUseCache(
+    $cache_granularity,
     $repository_version) {
+
     if ($this->commitHookMode) {
       return false;
     }
@@ -580,5 +581,4 @@ abstract class ArcanistLintEngine {
     return $this;
   }
 
-
 }

src/lint/engine/ArcanistSingleLintEngine.php

@@ -8,8 +8,6 @@
  *
  * Set which linter should be run by configuring `lint.engine.single.linter` in
  * `.arcconfig` or user config.
- *
- * @group linter
  */
 final class ArcanistSingleLintEngine extends ArcanistLintEngine {
 
@@ -60,4 +58,5 @@ final class ArcanistSingleLintEngine extends ArcanistLintEngine {
 
     return array($linter);
   }
+
 }

src/lint/engine/ComprehensiveLintEngine.php

@@ -1,9 +1,7 @@
 <?php
 
 /**
- * Basic lint engine which just applies several linters based on the file types
+ * Basic lint engine which just applies several linters based on the file types.
- *
- * @group linter
  */
 final class ComprehensiveLintEngine extends ArcanistLintEngine {
 

src/lint/engine/UnitTestableArcanistLintEngine.php

@@ -3,8 +3,6 @@
 /**
  * Lint engine for use in constructing test cases. See
  * @{class:ArcanistLinterTestCase}.
- *
- * @group testcase
  */
 final class UnitTestableArcanistLintEngine extends ArcanistLintEngine {
 

src/lint/linter/ArcanistConduitLinter.php

@@ -85,18 +85,17 @@ final class ArcanistConduitLinter extends ArcanistLinter {
     // customization directly.
     throw new ArcanistUsageException(
       'ArcanistConduitLinter does not support client-side severity '.
-      'customization.'
+      'customization.');
-    );
   }
 
   public function getLintNameMap() {
     // See getLintSeverityMap for rationale.
     throw new ArcanistUsageException(
-      'ArcanistConduitLinter does not support a name map.'
+      'ArcanistConduitLinter does not support a name map.');
-    );
   }
 
   protected function canCustomizeLintSeverities() {
     return false;
   }
+
 }

src/lint/linter/ArcanistJSONLintLinter.php

@@ -93,4 +93,5 @@ final class ArcanistJSONLintLinter extends ArcanistExternalLinter {
 
     return $messages;
   }
+
 }

src/lint/linter/ArcanistLinter.php

@@ -4,7 +4,6 @@
  * Implements lint rules, like syntax checks for a specific language.
  *
  * @task info Human Readable Information
- *
  * @stable
  */
 abstract class ArcanistLinter {

src/lint/linter/ArcanistMergeConflictLinter.php

@@ -50,4 +50,5 @@ final class ArcanistMergeConflictLinter extends ArcanistLinter {
       self::LINT_MERGECONFLICT => pht('Unresolved merge conflict'),
     );
   }
+
 }

src/lint/linter/ArcanistPhpcsLinter.php

@@ -2,8 +2,6 @@
 
 /**
  * Uses "PHP_CodeSniffer" to detect checkstyle errors in PHP code.
- *
- * @group linter
  */
 final class ArcanistPhpcsLinter extends ArcanistExternalLinter {
 

src/lint/linter/ArcanistPuppetLintLinter.php

@@ -103,4 +103,5 @@ final class ArcanistPuppetLintLinter extends ArcanistExternalLinter {
 
     return $messages;
   }
+
 }

src/lint/linter/ArcanistPyLintLinter.php

@@ -48,20 +48,18 @@
  *   (E) error, for probable bugs in the code
  *   (F) fatal, if an error occurred which prevented pylint from
  *       doing further processing.
- *
- * @group linter
  */
 final class ArcanistPyLintLinter extends ArcanistLinter {
 
   private function getMessageCodeSeverity($code) {
     $config = $this->getEngine()->getConfigurationManager();
 
-    $error_regexp   =
+    $error_regexp   = $config->getConfigFromAnySource(
-      $config->getConfigFromAnySource('lint.pylint.codes.error');
+      'lint.pylint.codes.error');
-    $warning_regexp =
+    $warning_regexp = $config->getConfigFromAnySource(
-      $config->getConfigFromAnySource('lint.pylint.codes.warning');
+      'lint.pylint.codes.warning');
-    $advice_regexp  =
+    $advice_regexp  = $config->getConfigFromAnySource(
-      $config->getConfigFromAnySource('lint.pylint.codes.advice');
+      'lint.pylint.codes.advice');
 
     if (!$error_regexp && !$warning_regexp && !$advice_regexp) {
       throw new ArcanistUsageException(

src/lint/linter/ArcanistScriptAndRegexLinter.php

@@ -152,8 +152,6 @@
  * @task  linterinfo  Linter Information
  * @task  parse       Parsing Output
  * @task  config      Validating Configuration
- *
- * @group linter
  */
 final class ArcanistScriptAndRegexLinter extends ArcanistLinter {
 

src/lint/linter/__tests__/ArcanistLinterTestCase.php

@@ -195,4 +195,5 @@ abstract class ArcanistLinterTestCase extends ArcanistPhutilTestCase {
       $actual,
       'File as patched by lint did not match the expected patched file.');
   }
+
 }

src/lint/linter/xhpast/ArcanistXHPASTLintNamingHook.php

@@ -7,7 +7,6 @@
  * @task override   Overriding Symbol Name Lint Messages
  * @task util       Name Utilities
  * @task internal   Internals
- * @group lint
  * @stable
  */
 abstract class ArcanistXHPASTLintNamingHook {

src/lint/linter/xhpast/ArcanistXHPASTLintSwitchHook.php

@@ -3,8 +3,6 @@
 /**
  * You can extend this class and set `xhpast.switchhook` in your `.arclint`
  * to have an opportunity to override results for linting `switch` statements.
- *
- * @group lint
  */
 abstract class ArcanistXHPASTLintSwitchHook {
 

src/lint/linter/xhpast/__tests__/ArcanistXHPASTLintNamingHookTestCase.php

@@ -2,8 +2,6 @@
 
 /**
  * Test cases for @{class:ArcanistXHPASTLintNamingHook}.
- *
- * @group testcase
  */
 final class ArcanistXHPASTLintNamingHookTestCase extends ArcanistTestCase {
 

src/lint/renderer/ArcanistLintCheckstyleXMLRenderer.php

@@ -2,8 +2,6 @@
 
 /**
  * Shows lint messages to the user.
- *
- * @group lint
  */
 final class ArcanistLintCheckstyleXMLRenderer extends ArcanistLintRenderer {
 
@@ -53,4 +51,5 @@ final class ArcanistLintCheckstyleXMLRenderer extends ArcanistLintRenderer {
     $this->writer->endDocument();
     return $this->writer->flush();
   }
+
 }

src/lint/renderer/ArcanistLintConsoleRenderer.php

@@ -2,10 +2,9 @@
 
 /**
  * Shows lint messages to the user.
- *
- * @group lint
  */
 final class ArcanistLintConsoleRenderer extends ArcanistLintRenderer {
+
   private $showAutofixPatches = false;
 
   public function setShowAutofixPatches($show_autofix_patches) {
@@ -234,7 +233,8 @@ final class ArcanistLintConsoleRenderer extends ArcanistLintRenderer {
   }
 
   public function renderOkayResult() {
-    return
+    return phutil_console_format(
-      phutil_console_format("<bg:green>** OKAY **</bg> No lint warnings.\n");
+      "<bg:green>** OKAY **</bg> No lint warnings.\n");
   }
+
 }

src/lint/renderer/ArcanistLintJSONRenderer.php

@@ -2,10 +2,9 @@
 
 /**
  * Shows lint messages to the user.
- *
- * @group lint
  */
 final class ArcanistLintJSONRenderer extends ArcanistLintRenderer {
+
   const LINES_OF_CONTEXT = 3;
 
   public function renderLintResult(ArcanistLintResult $result) {
@@ -32,4 +31,5 @@ final class ArcanistLintJSONRenderer extends ArcanistLintRenderer {
   public function renderOkayResult() {
     return '';
   }
+
 }

src/lint/renderer/ArcanistLintLikeCompilerRenderer.php

@@ -2,10 +2,9 @@
 
 /**
  * Shows lint messages to the user.
- *
- * @group lint
  */
 final class ArcanistLintLikeCompilerRenderer extends ArcanistLintRenderer {
+
   public function renderLintResult(ArcanistLintResult $result) {
     $lines = array();
     $messages = $result->getMessages();
@@ -32,4 +31,5 @@ final class ArcanistLintLikeCompilerRenderer extends ArcanistLintRenderer {
   public function renderOkayResult() {
     return '';
   }
+
 }

src/lint/renderer/ArcanistLintNoneRenderer.php

@@ -1,8 +1,5 @@
 <?php
 
-/**
- * @group lint
- */
 final class ArcanistLintNoneRenderer extends ArcanistLintRenderer {
 
   public function renderLintResult(ArcanistLintResult $result) {

src/lint/renderer/ArcanistLintRenderer.php

@@ -2,8 +2,6 @@
 
 /**
  * Shows lint messages to the user.
- *
- * @group lint
  */
 abstract class ArcanistLintRenderer {
 

src/lint/renderer/ArcanistLintSummaryRenderer.php

@@ -2,10 +2,9 @@
 
 /**
  * Shows lint messages to the user.
- *
- * @group lint
  */
 final class ArcanistLintSummaryRenderer extends ArcanistLintRenderer {
+
   public function renderLintResult(ArcanistLintResult $result) {
     $messages = $result->getMessages();
     $path = $result->getPath();
@@ -24,7 +23,8 @@ final class ArcanistLintSummaryRenderer extends ArcanistLintRenderer {
   }
 
   public function renderOkayResult() {
-    return
+    return phutil_console_format(
-      phutil_console_format("<bg:green>** OKAY **</bg> No lint warnings.\n");
+      "<bg:green>** OKAY **</bg> No lint warnings.\n");
   }
+
 }

src/parser/ArcanistBaseCommitParser.php

@@ -91,7 +91,6 @@ final class ArcanistBaseCommitParser {
    * Handle resolving individual rules.
    */
   private function resolveRule($rule, $source) {
-
     // NOTE: Returning `null` from this method means "no match".
     // Returning `false` from this method means "stop current ruleset".
 

src/parser/ArcanistBundle.php

@@ -2,8 +2,6 @@
 
 /**
  * Converts changesets between different formats.
- *
- * @group diff
  */
 final class ArcanistBundle {
 
@@ -108,7 +106,6 @@ final class ArcanistBundle {
   }
 
   private function getEOL($patch_type) {
-
     // NOTE: Git always generates "\n" line endings, even under Windows, and
     // can not parse certain patches with "\r\n" line endings. SVN generates
     // patches with "\n" line endings on Mac or Linux and "\r\n" line endings
@@ -198,9 +195,7 @@ final class ArcanistBundle {
     return $obj;
   }
 
-  private function __construct() {
+  private function __construct() {}
-
-  }
 
   public function writeToDisk($path) {
     $changes = $this->getChanges();
@@ -260,7 +255,6 @@ final class ArcanistBundle {
   }
 
   public function toUnifiedDiff() {
-
     $eol = $this->getEOL('unified');
 
     $result = array();

src/parser/ArcanistDiffParser.php

@@ -2,8 +2,6 @@
 
 /**
  * Parses diffs from a working copy.
- *
- * @group diff
  */
 final class ArcanistDiffParser {
 
@@ -453,7 +451,6 @@ final class ArcanistDiffParser {
   }
 
   private function parseSVNPropertyChange($op, $prop) {
-
     $old = array();
     $new = array();
 
@@ -1378,7 +1375,6 @@ final class ArcanistDiffParser {
    * Returns a parseable normal diff and a textual commit message.
    */
   private function stripGitFormatPatch($diff) {
-
     // We can parse this by splitting it into two pieces over and over again
     // along different section dividers:
     //

src/parser/__tests__/ArcanistDiffParserTestCase.php

@@ -2,8 +2,6 @@
 
 /**
  * Test cases for @{class:ArcanistDiffParser}.
- *
- * @group testcase
  */
 final class ArcanistDiffParserTestCase extends ArcanistTestCase {
 

src/parser/diff/ArcanistDiffChange.php

@@ -2,8 +2,6 @@
 
 /**
  * Represents a change to an individual path.
- *
- * @group diff
  */
 final class ArcanistDiffChange {
 

src/parser/diff/ArcanistDiffChangeType.php

@@ -2,10 +2,9 @@
 
 /**
  * Defines constants for file types and operations in changesets.
- *
- * @group diff
  */
 final class ArcanistDiffChangeType {
+
   const TYPE_ADD        = 1;
   const TYPE_CHANGE     = 2;
   const TYPE_DELETE     = 3;

src/parser/diff/ArcanistDiffHunk.php

@@ -2,8 +2,6 @@
 
 /**
  * Represents a contiguous set of added and removed lines in a diff.
- *
- * @group diff
  */
 final class ArcanistDiffHunk {
 

src/repository/api/ArcanistGitAPI.php

@@ -2,8 +2,6 @@
 
 /**
  * Interfaces with Git working copies.
- *
- * @group workingcopy
  */
 final class ArcanistGitAPI extends ArcanistRepositoryAPI {
 
@@ -24,7 +22,6 @@ final class ArcanistGitAPI extends ArcanistRepositoryAPI {
   }
 
   protected function buildLocalFuture(array $argv) {
-
     $argv[0] = 'git '.$argv[0];
 
     $future = newv('ExecFuture', $argv);
@@ -547,8 +544,8 @@ final class ArcanistGitAPI extends ArcanistRepositoryAPI {
       'svn find-rev %s',
       $input);
     if (!$stdout) {
-      throw new ArcanistUsageException("Cannot find the {$vcs} equivalent "
+      throw new ArcanistUsageException(
-                                       ."of {$input}.");
+        "Cannot find the {$vcs} equivalent of {$input}.");
     }
     // When git performs a partial-rebuild during svn
     // look-up, we need to parse the final line
@@ -834,7 +831,6 @@ final class ArcanistGitAPI extends ArcanistRepositoryAPI {
   }
 
   private function getFileDataAtRevision($path, $revision) {
-
     // NOTE: We don't want to just "git show {$revision}:{$path}" since if the
     // path was a directory at the given revision we'll get a list of its files
     // and treat it as though it as a file containing a list of other files,

src/repository/api/ArcanistMercurialAPI.php

@@ -2,8 +2,6 @@
 
 /**
  * Interfaces with the Mercurial working copies.
- *
- * @group workingcopy
  */
 final class ArcanistMercurialAPI extends ArcanistRepositoryAPI {
 
@@ -15,7 +13,6 @@ final class ArcanistMercurialAPI extends ArcanistRepositoryAPI {
   private $supportsPhases;
 
   protected function buildLocalFuture(array $argv) {
-
     // Mercurial has a "defaults" feature which basically breaks automation by
     // allowing the user to add random flags to any command. This feature is
     // "deprecated" and "a bad idea" that you should "forget ... existed"
@@ -82,8 +79,8 @@ final class ArcanistMercurialAPI extends ArcanistRepositoryAPI {
       '{node}',
        $string);
     if (!$stdout) {
-      throw new ArcanistUsageException("Cannot find the HG equivalent "
+      throw new ArcanistUsageException(
-                                       ."of {$revision_id} given.");
+        "Cannot find the HG equivalent of {$revision_id} given.");
     }
     return $stdout;
   }
@@ -94,8 +91,8 @@ final class ArcanistMercurialAPI extends ArcanistRepositoryAPI {
     list($stdout) = $this->execxLocal(
       'log -r %s --template {svnrev}', $hash);
     if (!$stdout) {
-      throw new ArcanistUsageException("Cannot find the SVN equivalent "
+      throw new ArcanistUsageException(
-                                       ."of {$hash} given.");
+        "Cannot find the SVN equivalent of {$hash} given.");
     }
     return $stdout;
   }
@@ -133,8 +130,9 @@ final class ArcanistMercurialAPI extends ArcanistRepositoryAPI {
         }
       }
 
-      $this->setBaseCommitExplanation('it is the greatest common ancestor of '.
+      $this->setBaseCommitExplanation(
-        'the working directory and the commit you specified explicitly.');
+        'it is the greatest common ancestor of the working directory '.
+        'and the commit you specified explicitly.');
       return $commit;
     }
 
@@ -731,10 +729,10 @@ final class ArcanistMercurialAPI extends ArcanistRepositoryAPI {
   }
 
   /**
-   * Parse the Mercurial author field
+   * Parse the Mercurial author field.
    *
    * Not everyone enters their email address as a part of the username
-   * field. Try to make it work when it's obvious
+   * field. Try to make it work when it's obvious.
    *
    * @param string $full_author
    * @return array
@@ -762,9 +760,7 @@ final class ArcanistMercurialAPI extends ArcanistRepositoryAPI {
   public function doCommit($message) {
     $tmp_file = new TempFile();
     Filesystem::writeFile($tmp_file, $message);
-    $this->execxLocal(
+    $this->execxLocal('commit -l %s', $tmp_file);
-      'commit -l %s',
-      $tmp_file);
     $this->reloadWorkingCopy();
   }
 

src/repository/api/ArcanistRepositoryAPI.php

@@ -4,7 +4,6 @@
  * Interfaces with the VCS in the working copy.
  *
  * @task  status      Path Status
- * @group workingcopy
  */
 abstract class ArcanistRepositoryAPI {
 

src/repository/api/ArcanistSubversionAPI.php

@@ -2,8 +2,6 @@
 
 /**
  * Interfaces with Subversion working copies.
- *
- * @group workingcopy
  */
 final class ArcanistSubversionAPI extends ArcanistRepositoryAPI {
 
@@ -316,7 +314,6 @@ final class ArcanistSubversionAPI extends ArcanistRepositoryAPI {
   }
 
   public function getSVNInfo($path) {
-
     if (empty($this->svnInfo[$path])) {
 
       if (empty($this->svnInfoRaw[$path])) {

src/repository/api/__tests__/ArcanistRepositoryAPIStateTestCase.php

@@ -120,5 +120,4 @@ final class ArcanistRepositoryAPIStateTestCase extends ArcanistTestCase {
     }
   }
 
-
 }

src/repository/hookapi/ArcanistHookAPI.php

@@ -1,7 +1,7 @@
 <?php
 
 /**
- * API while running in the context of a commit hook
+ * API while running in the context of a commit hook.
  */
 abstract class ArcanistHookAPI {
   abstract public function getCurrentFileData($path);

src/repository/hookapi/ArcanistSubversionHookAPI.php

@@ -32,4 +32,5 @@ final class ArcanistSubversionHookAPI extends ArcanistHookAPI {
       $this->root."/$path");
     return ($err ? null : $file);
   }
+
 }

src/repository/parser/ArcanistMercurialParser.php

@@ -5,7 +5,6 @@
  * provides low-level APIs for reading "hg" output.
  *
  * @task  parse Parsing "hg" Output
- * @group workingcopy
  */
 final class ArcanistMercurialParser {
 

src/repository/parser/__tests__/ArcanistMercurialParserTestCase.php

@@ -85,4 +85,5 @@ final class ArcanistMercurialParserTestCase extends ArcanistTestCase {
         throw new Exception("No test information for test data '{$name}'!");
     }
   }
+
 }

src/unit/ArcanistUnitTestResult.php

@@ -2,8 +2,6 @@
 
 /**
  * Represents the outcome of running a unit test.
- *
- * @group unit
  */
 final class ArcanistUnitTestResult {
 
@@ -78,8 +76,8 @@ final class ArcanistUnitTestResult {
   }
 
   /**
-   * "extra data" allows an implementation to store additional
+   * "extra data" allows an implementation to store additional key/value
-   * key/value metadata along with the result of the test run.
+   * metadata along with the result of the test run.
    */
   public function setExtraData(array $extra_data = null) {
     $this->extraData = $extra_data;

src/unit/engine/ArcanistBaseTestResultParser.php

@@ -1,7 +1,7 @@
 <?php
 
 /**
- * Abstract Base class for test result parsers
+ * Abstract Base class for test result parsers.
  */
 abstract class ArcanistBaseTestResultParser {
 
@@ -12,25 +12,21 @@ abstract class ArcanistBaseTestResultParser {
 
   public function setEnableCoverage($enable_coverage) {
     $this->enableCoverage = $enable_coverage;
-
     return $this;
   }
 
   public function setProjectRoot($project_root) {
     $this->projectRoot = $project_root;
-
     return $this;
   }
 
   public function setCoverageFile($coverage_file) {
     $this->coverageFile = $coverage_file;
-
     return $this;
   }
 
   public function setAffectedTests($affected_tests) {
     $this->affectedTests = $affected_tests;
-
     return $this;
   }
 
@@ -49,4 +45,5 @@ abstract class ArcanistBaseTestResultParser {
    * @return array ArcanistUnitTestResult
    */
   abstract public function parseTestResults($path, $test_results);
+
 }

src/unit/engine/ArcanistBaseUnitTestEngine.php

@@ -2,8 +2,6 @@
 
 /**
  * Manages unit test execution.
- *
- * @group unit
  */
 abstract class ArcanistBaseUnitTestEngine {
 
@@ -105,12 +103,13 @@ abstract class ArcanistBaseUnitTestEngine {
   abstract public function run();
 
   /**
-   * Modify the return value of this function in the child class, if
+   * Modify the return value of this function in the child class, if you do
-   * you do not need to echo the test results after all the tests have
+   * not need to echo the test results after all the tests have been run. This
-   * been run. This is the case for example when the child class
+   * is the case for example when the child class prints the tests results
-   * prints the tests results while the tests are running.
+   * while the tests are running.
    */
   public function shouldEchoTestResults() {
     return true;
   }
+
 }

src/unit/engine/ArcanistXUnitTestResultParser.php

@@ -2,14 +2,12 @@
 
 /**
  * Parser for JUnit, NUnit, etc results format - https://gist.github.com/959290
- *
- * @group unitrun
  */
 final class ArcanistXUnitTestResultParser {
 
   /**
    * Parse test results from provided input and return an array
-   * of ArcanistUnitTestResult
+   * of @{class:ArcanistUnitTestResult}.
    *
    * @param string $test_results String containing test results
    *
@@ -42,7 +40,7 @@ final class ArcanistXUnitTestResultParser {
       $user_data = '';
 
       // A skipped test is a test which was ignored using framework
-      // mechanizms (e.g. @skip decorator)
+      // mechanisms (e.g. @skip decorator)
       $skipped = $testcase->getElementsByTagName('skipped');
       if ($skipped->length > 0) {
         $status = ArcanistUnitTestResult::RESULT_SKIP;
@@ -55,7 +53,7 @@ final class ArcanistXUnitTestResultParser {
       }
 
       // Failure is a test which the code has explicitly failed by using
-      // the mechanizms for that purpose. e.g., via an assertEquals
+      // the mechanisms for that purpose. e.g., via an assertEquals
       $failures = $testcase->getElementsByTagName('failure');
       if ($failures->length > 0) {
         $status = ArcanistUnitTestResult::RESULT_FAIL;
@@ -68,8 +66,7 @@ final class ArcanistXUnitTestResultParser {
       }
 
       // An errored test is one that had an unanticipated problem. e.g., an
-      // unchecked throwable, or a problem with an implementation of the
+      // unchecked throwable, or a problem with an implementation of the test.
-      // test.
       $errors = $testcase->getElementsByTagName('error');
       if ($errors->length > 0) {
         $status = ArcanistUnitTestResult::RESULT_BROKEN;

src/unit/engine/CSharpToolsTestEngine.php

@@ -6,10 +6,7 @@
  * This engine inherits from `XUnitTestEngine`, where xUnit is used to actually
  * run the unit tests and this class provides a thin layer on top to collect
  * code coverage data with a third-party tool.
- *
- * @group unitrun
  */
-
 final class CSharpToolsTestEngine extends XUnitTestEngine {
 
   private $cscoverHintPath;
@@ -19,19 +16,17 @@ final class CSharpToolsTestEngine extends XUnitTestEngine {
   private $excludedFiles;
 
   /**
-   * Overridden version of `loadEnvironment` to support a different set
+   * Overridden version of `loadEnvironment` to support a different set of
-   * of configuration values and to pull in the cstools config for
+   * configuration values and to pull in the cstools config for code coverage.
-   * code coverage.
    */
   protected function loadEnvironment() {
-
     $config = $this->getConfigurationManager();
-    $this->cscoverHintPath =
+    $this->cscoverHintPath = $config->getConfigFromAnySource(
-      $config->getConfigFromAnySource('unit.csharp.cscover.binary');
+      'unit.csharp.cscover.binary');
-    $this->matchRegex =
+    $this->matchRegex = $config->getConfigFromAnySource(
-      $config->getConfigFromAnySource('unit.csharp.coverage.match');
+      'unit.csharp.coverage.match');
-    $this->excludedFiles =
+    $this->excludedFiles = $config->getConfigFromAnySource(
-      $config->getConfigFromAnySource('unit.csharp.coverage.excluded');
+      'unit.csharp.coverage.excluded');
 
     parent::loadEnvironment();
 
@@ -50,10 +45,8 @@ final class CSharpToolsTestEngine extends XUnitTestEngine {
       $this->coverEngine = Filesystem::resolvePath($cscover);
     } else {
       throw new Exception(
-        'Unable to locate cscover coverage runner '.
+        'Unable to locate cscover coverage runner (have you built yet?)');
-        '(have you built yet?)');
     }
-
   }
 
   /**
@@ -283,4 +276,5 @@ final class CSharpToolsTestEngine extends XUnitTestEngine {
     $this->addCachedResults($cover_file, $reports);
     return $reports;
   }
+
 }

src/unit/engine/GoTestResultParser.php

@@ -3,13 +3,7 @@
 /**
  * Go Test Result Parsing utility
  *
- * Intended to enable custom unit engines derived
+ * (To generate test output, run something like: `go test -v`)
- * from Go's built-in test utility to reuse
- * common business logic related to parsing
- * Go test results.
- *
- * (To generate test output, run something like:
- * `go test -v`)
  */
 final class GoTestResultParser extends ArcanistBaseTestResultParser {
 
@@ -23,7 +17,6 @@ final class GoTestResultParser extends ArcanistBaseTestResultParser {
    * @return array
    */
   public function parseTestResults($path, $test_results) {
-
     $test_results = explode("\n", $test_results);
 
     $results = array();
@@ -137,4 +130,5 @@ final class GoTestResultParser extends ArcanistBaseTestResultParser {
 
     return $test_case_results;
   }
+
 }

src/unit/engine/NoseTestEngine.php

@@ -4,13 +4,10 @@
  * Very basic 'nose' unit test engine wrapper.
  *
  * Requires nose 1.1.3 for code coverage.
- *
- * @group unitrun
  */
 final class NoseTestEngine extends ArcanistBaseUnitTestEngine {
 
   public function run() {
-
     $paths = $this->getPaths();
 
     $affected_tests = array();
@@ -52,9 +49,7 @@ final class NoseTestEngine extends ArcanistBaseUnitTestEngine {
       $xunit_tmp = new TempFile();
       $cover_tmp = new TempFile();
 
-      $future = $this->buildTestFuture($test_path,
+      $future = $this->buildTestFuture($test_path, $xunit_tmp, $cover_tmp);
-                                       $xunit_tmp,
-                                       $cover_tmp);
 
       $futures[$test_path] = $future;
       $tmpfiles[$test_path] = array(
@@ -91,8 +86,8 @@ final class NoseTestEngine extends ArcanistBaseUnitTestEngine {
                          $xunit_tmp);
 
     if ($this->getEnableCoverage() !== false) {
-      $cmd_line .= csprintf(' --with-coverage --cover-xml '.
+      $cmd_line .= csprintf(
-                            '--cover-xml-file=%s',
+        ' --with-coverage --cover-xml --cover-xml-file=%s',
         $cover_tmp);
     }
 

src/unit/engine/PhpunitResultParser.php

@@ -3,13 +3,8 @@
 /**
  * PHPUnit Result Parsing utility
  *
- * Intended to enable custom unit engines derived
+ * For an example on how to integrate with your test engine, see
- * from phpunit to reuse common business logic related
+ * @{class:PhpunitTestEngine}.
- * to parsing phpunit test results and reports
- *
- * For an example on how to integrate with your test
- * engine, see PhpunitTestEngine.
- *
  */
 final class PhpunitResultParser extends ArcanistBaseTestResultParser {
 
@@ -22,7 +17,6 @@ final class PhpunitResultParser extends ArcanistBaseTestResultParser {
    * @return array
    */
   public function parseTestResults($path, $test_results) {
-
     if (!$test_results) {
       $result = id(new ArcanistUnitTestResult())
         ->setName($path)
@@ -163,7 +157,6 @@ final class PhpunitResultParser extends ArcanistBaseTestResultParser {
    * valid.
    *
    * @param string $json String containing JSON report
-   *
    * @return array JSON decoded array
    */
   private function getJsonReport($json) {
@@ -186,4 +179,5 @@ final class PhpunitResultParser extends ArcanistBaseTestResultParser {
 
     return $json;
   }
+
 }

src/unit/engine/PhpunitTestEngine.php

@@ -1,15 +1,7 @@
 <?php
 
 /**
- * PHPUnit wrapper
+ * PHPUnit wrapper.
- *
- * To use, set unit.engine in .arcconfig, or use --engine flag
- * with arc unit. Currently supports only class & test files
- * (no directory support).
- * To use custom phpunit configuration, set phpunit_config in
- * .arcconfig (e.g. app/phpunit.xml.dist).
- *
- * @group unitrun
  */
 final class PhpunitTestEngine extends ArcanistBaseUnitTestEngine {
 
@@ -19,7 +11,6 @@ final class PhpunitTestEngine extends ArcanistBaseUnitTestEngine {
   private $projectRoot;
 
   public function run() {
-
     $this->projectRoot = $this->getWorkingCopy()->getProjectRoot();
     $this->affectedTests = array();
     foreach ($this->getPaths() as $path) {
@@ -79,8 +70,6 @@ final class PhpunitTestEngine extends ArcanistBaseUnitTestEngine {
         'json' => $json_tmp,
         'clover' => $clover_tmp,
       );
-
-
     }
 
     $results = array();
@@ -99,7 +88,7 @@ final class PhpunitTestEngine extends ArcanistBaseUnitTestEngine {
   }
 
   /**
-   * Parse test results from phpunit json report
+   * Parse test results from phpunit json report.
    *
    * @param string $path Path to test
    * @param string $json_tmp Path to phpunit json report
@@ -257,8 +246,8 @@ final class PhpunitTestEngine extends ArcanistBaseUnitTestEngine {
   }
 
   /**
-   * Tries to find and update phpunit configuration file
+   * Tries to find and update phpunit configuration file based on
-   * based on phpunit_config option in .arcconfig
+   * `phpunit_config` option in `.arcconfig`.
    */
   private function prepareConfigFile() {
     $project_root = $this->projectRoot.DIRECTORY_SEPARATOR;
@@ -284,4 +273,5 @@ final class PhpunitTestEngine extends ArcanistBaseUnitTestEngine {
       }
     }
   }
+
 }

src/unit/engine/PhutilUnitTestEngine.php

@@ -2,8 +2,6 @@
 
 /**
  * Very basic unit test engine which runs libphutil tests.
- *
- * @group unitrun
  */
 final class PhutilUnitTestEngine extends ArcanistBaseUnitTestEngine {
 

src/unit/engine/PytestTestEngine.php

@@ -2,8 +2,6 @@
 
 /**
  * Very basic 'py.test' unit test engine wrapper.
- *
- * @group unitrun
  */
 final class PytestTestEngine extends ArcanistBaseUnitTestEngine {
 
@@ -27,12 +25,13 @@ final class PytestTestEngine extends ArcanistBaseUnitTestEngine {
   public function buildTestFuture($junit_tmp, $cover_tmp) {
     $paths = $this->getPaths();
 
-    $cmd_line = csprintf('py.test --junitxml %s',
+    $cmd_line = csprintf('py.test --junitxml %s', $junit_tmp);
-                         $junit_tmp);
 
     if ($this->getEnableCoverage() !== false) {
-      $cmd_line = csprintf('coverage run --source %s -m %C',
+      $cmd_line = csprintf(
-                           $this->project_root, $cmd_line);
+        'coverage run --source %s -m %C',
+        $this->project_root,
+        $cmd_line);
     }
 
     return new ExecFuture('%C', $cmd_line);
@@ -132,4 +131,5 @@ final class PytestTestEngine extends ArcanistBaseUnitTestEngine {
 
     return $reports;
   }
+
 }

src/unit/engine/XUnitTestEngine.php

@@ -7,7 +7,6 @@
  * that the test assembly that verifies the functionality of `SomeAssembly` is
  * located at `SomeAssembly.Tests`.
  *
- * @group unitrun
  * @concrete-extensible
  */
 class XUnitTestEngine extends ArcanistBaseUnitTestEngine {
@@ -27,10 +26,10 @@ class XUnitTestEngine extends ArcanistBaseUnitTestEngine {
   }
 
   /**
-   * Determines what executables and test paths to use.  Between platforms
+   * Determines what executables and test paths to use. Between platforms this
-   * this also changes whether the test engine is run under .NET or Mono.  It
+   * also changes whether the test engine is run under .NET or Mono. It also
-   * also ensures that all of the required binaries are available for the tests
+   * ensures that all of the required binaries are available for the tests to
-   * to run successfully.
+   * run successfully.
    *
    * @return void
    */
@@ -84,8 +83,8 @@ class XUnitTestEngine extends ArcanistBaseUnitTestEngine {
   }
 
   /**
-   * Main entry point for the test engine.  Determines what assemblies to
+   * Main entry point for the test engine. Determines what assemblies to build
-   * build and test based on the files that have changed.
+   * and test based on the files that have changed.
    *
    * @return array   Array of test results.
    */
@@ -137,7 +136,8 @@ class XUnitTestEngine extends ArcanistBaseUnitTestEngine {
               if (!$exists) {
                 $results[] = array(
                   'project' => $project,
-                  'assembly' => $assembly);
+                  'assembly' => $assembly,
+                );
               }
             }
           }
@@ -202,7 +202,6 @@ class XUnitTestEngine extends ArcanistBaseUnitTestEngine {
    * @return array   Array of test results.
    */
   private function generateProjects() {
-
     // No "Build" directory; so skip generation of projects.
     if (!is_dir(Filesystem::resolvePath($this->projectRoot.'/Build'))) {
       return array();
@@ -302,9 +301,8 @@ class XUnitTestEngine extends ArcanistBaseUnitTestEngine {
   }
 
   /**
-   * Build the future for running a unit test.  This can be
+   * Build the future for running a unit test. This can be overridden to enable
-   * overridden to enable support for code coverage via
+   * support for code coverage via another tool.
-   * another tool
    *
    * @param  string  Name of the test assembly.
    * @return array   The future, output filename and coverage filename
@@ -340,7 +338,6 @@ class XUnitTestEngine extends ArcanistBaseUnitTestEngine {
    * @return array   Array of test results.
    */
   private function testAssemblies(array $test_assemblies) {
-
     $results = array();
 
     // Build the futures for running the tests.
@@ -374,7 +371,6 @@ class XUnitTestEngine extends ArcanistBaseUnitTestEngine {
 
         // Since it's not possible for the user to correct this error, we
         // ignore the fact the tests didn't run here.
-        //
       }
     }
 
@@ -383,8 +379,8 @@ class XUnitTestEngine extends ArcanistBaseUnitTestEngine {
 
   /**
    * Returns null for this implementation as xUnit does not support code
-   * coverage directly.  Override this method in another class to provide
+   * coverage directly. Override this method in another class to provide code
-   * code coverage information (also see `CSharpToolsUnitEngine`).
+   * coverage information (also see @{class:CSharpToolsUnitEngine}).
    *
    * @param  string  The name of the coverage file if one was provided by
    *                 `buildTestFuture`.

src/unit/engine/__tests__/GoTestResultParserTestCase.php

@@ -2,11 +2,6 @@
 
 /**
  * Test for @{class:GoTestResultParser}.
- *
- * (putting tests in your tests so you can test
- * while you test)
- *
- * @group testcase
  */
 final class GoTestResultParserTestCase extends ArcanistTestCase {
 
@@ -107,4 +102,5 @@ final class GoTestResultParserTestCase extends ArcanistTestCase {
         $result->getResult());
     }
   }
+
 }

src/unit/engine/__tests__/PHPUnitTestEngineTestCase.php

@@ -2,13 +2,10 @@
 
 /**
  * Tests for @{class:PHPUnitTestEngine}.
- *
- * @group testcase
  */
 final class PHPUnitTestEngineTestCase extends ArcanistTestCase {
 
   public function testSearchLocations() {
-
     $path = '/path/to/some/file/X.php';
 
     $this->assertEqual(

src/unit/engine/__tests__/PhutilUnitTestEngineTestCase.php

@@ -2,8 +2,6 @@
 
 /**
  * Very meta test for @{class:PhutilUnitTestEngine}.
- *
- * @group testcase
  */
 final class PhutilUnitTestEngineTestCase extends ArcanistTestCase {
 

src/unit/engine/__tests__/XUnitTestResultParserTestCase.php

@@ -2,11 +2,6 @@
 
 /**
  * Test for @{class:ArcanistXUnitTestResultParser}.
- *
- * (putting tests in your tests so you can test
- * while you test)
- *
- * @group testcase
  */
 final class XUnitTestResultParserTestCase extends ArcanistTestCase {
 

src/unit/engine/phutil/ArcanistPhutilTestCase.php

@@ -388,9 +388,7 @@ abstract class ArcanistPhutilTestCase {
    *
    * @task internal
    */
-  final public function __construct() {
+  final public function __construct() {}
-
-  }
 
 
   /**

src/unit/engine/phutil/testcase/ArcanistPhutilTestCaseTestCase.php

@@ -2,8 +2,6 @@
 
 /**
  * Test for @{class:PhutilUnitTestEngineTestCase}.
- *
- * @group testcase
  */
 final class ArcanistPhutilTestCaseTestCase extends ArcanistPhutilTestCase {
 

src/unit/engine/phutil/testcase/ArcanistPhutilTestSkippedException.php

@@ -2,7 +2,5 @@
 
 /**
  * Thrown to skip test execution.
- *
- * @group unitrun
  */
 final class ArcanistPhutilTestSkippedException extends Exception {}

src/unit/engine/phutil/testcase/ArcanistPhutilTestTerminatedException.php

@@ -2,7 +2,5 @@
 
 /**
  * Thrown to prematurely end test execution.
- *
- * @group unitrun
  */
 final class ArcanistPhutilTestTerminatedException extends Exception {}

src/unit/renderer/ArcanistUnitConsoleRenderer.php

@@ -1,8 +1,5 @@
 <?php
 
-/**
- * @group unit
- */
 final class ArcanistUnitConsoleRenderer extends ArcanistUnitRenderer {
 
   public function renderUnitResult(ArcanistUnitTestResult $result) {

src/unit/renderer/ArcanistUnitRenderer.php

@@ -1,11 +1,6 @@
 <?php
 
-/**
- * @group unit
- */
 abstract class ArcanistUnitRenderer {
-
   abstract public function renderUnitResult(ArcanistUnitTestResult $result);
   abstract public function renderPostponedResult($count);
-
 }

src/workflow/ArcanistAliasWorkflow.php

@@ -2,8 +2,6 @@
 
 /**
  * Manages aliases for commands with options.
- *
- * @group workflow
  */
 final class ArcanistAliasWorkflow extends ArcanistBaseWorkflow {
 

src/workflow/ArcanistAnoidWorkflow.php

@@ -1,8 +1,5 @@
 <?php
 
-/**
- * @group workflow
- */
 final class ArcanistAnoidWorkflow extends ArcanistBaseWorkflow {
 
   public function getWorkflowName() {

src/workflow/ArcanistBackoutWorkflow.php

@@ -1,10 +1,10 @@
 <?php
-/**
- * Runs git revert and assigns hi pri task to original author
- * @group workflow
- */
 
+/**
+ * Runs git revert and assigns a high priority task to original author.
+ */
 final class ArcanistBackoutWorkflow extends ArcanistBaseWorkflow {
+
   private $console;
   private $conduit;
   private $revision;
@@ -49,7 +49,9 @@ EOTEXT
     return true;
   }
 
-  // Given a differential revision ID, fetches the commit ID
+  /**
+   * Given a differential revision ID, fetches the commit ID.
+   */
   private function getCommitIDFromRevisionID($revision_id) {
     $conduit = $this->getConduit();
     $revisions = $conduit->callMethodSynchronous(
@@ -81,8 +83,10 @@ EOTEXT
     return $commit_id;
   }
 
-  // Fetches an array of commit info provided a Commit_id
+  /**
-  // in the form of rE123456 (not local commit hash)
+   * Fetches an array of commit info provided a Commit_id in the form of
+   * rE123456 (not local commit hash).
+   */
   private function getDiffusionCommit($commit_id) {
     $result = $this->getConduit()->callMethodSynchronous(
       'diffusion.getcommits',
@@ -97,13 +101,16 @@ EOTEXT
     return $commit;
   }
 
-  // Retrieves default template from differential and prefills info
+  /**
+   * Retrieves default template from differential and pre-fills info.
+   */
   private function buildCommitMessage($commit_hash) {
     $conduit = $this->getConduit();
     $repository_api = $this->getRepositoryAPI();
 
     $summary = $repository_api->getBackoutMessage($commit_hash);
-    $fields = array('summary' => $summary,
+    $fields = array(
+      'summary' => $summary,
       'testPlan' => 'revert-hammer',
     );
     $template = $conduit->callMethodSynchronous(
@@ -119,7 +126,9 @@ EOTEXT
     return $template;
   }
 
-  // Performs the backout/revert of a revision and creates a commit
+  /**
+   * Performs the backout/revert of a revision and creates a commit.
+   */
   public function run() {
     $console = PhutilConsole::getConsole();
     $conduit = $this->getConduit();
@@ -163,8 +172,8 @@ EOTEXT
       $commit_hash = $input[0];
     }
     if (!$repository_api->hasLocalCommit($commit_hash)) {
-      throw new ArcanistUsageException('Invalid commit provided or does not'.
+      throw new ArcanistUsageException(
-                                        'exist in the working copy!');
+        'Invalid commit provided or does not exist in the working copy!');
     }
 
     // Run 'backout'.
@@ -177,6 +186,6 @@ EOTEXT
     $message = $this->buildCommitMessage($commit_hash);
     $repository_api->doCommit($message);
     $console->writeOut("Double-check the commit and push when ready\n");
-
   }
+
 }

src/workflow/ArcanistBaseWorkflow.php

@@ -76,9 +76,7 @@ abstract class ArcanistBaseWorkflow extends Phobject {
   private $changeCache = array();
 
 
-  public function __construct() {
+  public function __construct() {}
-
-  }
 
 
   abstract public function run();
@@ -320,11 +318,13 @@ abstract class ArcanistBaseWorkflow extends Phobject {
       }
 
       if (empty($credentials['user'])) {
-        throw new ConduitClientException('ERR-INVALID-USER',
+        throw new ConduitClientException(
+          'ERR-INVALID-USER',
           'Empty user in credentials.');
       }
       if (empty($credentials['certificate'])) {
-        throw new ConduitClientException('ERR-NO-CERTIFICATE',
+        throw new ConduitClientException(
+          'ERR-NO-CERTIFICATE',
           'Empty certificate in credentials.');
       }
 

src/workflow/ArcanistBookmarkWorkflow.php

@@ -1,9 +1,7 @@
 <?php
 
 /**
- * Alias for arc feature
+ * Alias for `arc feature`.
- *
- * @group workflow
  */
 final class ArcanistBookmarkWorkflow extends ArcanistFeatureWorkflow {
 

src/workflow/ArcanistBranchWorkflow.php

@@ -1,9 +1,7 @@
 <?php
 
 /**
- * Alias for arc feature
+ * Alias for `arc feature`.
- *
- * @group workflow
  */
 final class ArcanistBranchWorkflow extends ArcanistFeatureWorkflow {
 

src/workflow/ArcanistBrowseWorkflow.php

@@ -137,4 +137,5 @@ EOTEXT
         "Unable to find a browser command to run. Set 'browser' in your ".
         "arc config to specify one."));
   }
+
 }

src/workflow/ArcanistCallConduitWorkflow.php

@@ -2,8 +2,6 @@
 
 /**
  * Provides command-line access to the Conduit API.
- *
- * @group workflow
  */
 final class ArcanistCallConduitWorkflow extends ArcanistBaseWorkflow {
 
@@ -91,4 +89,5 @@ EOTEXT
 
     return 0;
   }
+
 }

src/workflow/ArcanistCloseRevisionWorkflow.php

@@ -2,8 +2,6 @@
 
 /**
  * Explicitly closes Differential revisions.
- *
- * @group workflow
  */
 final class ArcanistCloseRevisionWorkflow extends ArcanistBaseWorkflow {
 
@@ -151,4 +149,5 @@ EOTEXT
 
     return 0;
   }
+
 }

src/workflow/ArcanistCloseWorkflow.php

@@ -1,9 +1,7 @@
 <?php
 
 /**
- * Close a task
+ * Close a task.
- *
- * @group workflow
  */
 final class ArcanistCloseWorkflow extends ArcanistBaseWorkflow {
 
@@ -73,7 +71,8 @@ EOTEXT
       'status'  => array(
         'param' => 'status',
         'short' => 's',
-        'help'  => pht('Specify a new status. Valid status options can be '.
+        'help'  => pht(
+          'Specify a new status. Valid status options can be '.
           'seen with the `list-statuses` argument.'),
       ),
       'list-statuses' => array(

src/workflow/ArcanistCommitWorkflow.php

@@ -2,8 +2,6 @@
 
 /**
  * Executes "svn commit" once a revision has been "Accepted".
- *
- * @group workflow
  */
 final class ArcanistCommitWorkflow extends ArcanistBaseWorkflow {
 
@@ -336,5 +334,4 @@ EOTEXT
     }
   }
 
-
 }

src/workflow/ArcanistCoverWorkflow.php

@@ -2,8 +2,6 @@
 
 /**
  * Covers your professional reputation by blaming changes to locate reviewers.
- *
- * @group workflow
  */
 final class ArcanistCoverWorkflow extends ArcanistBaseWorkflow {
 
@@ -63,7 +61,6 @@ EOTEXT
   }
 
   public function run() {
-
     $repository_api = $this->getRepositoryAPI();
 
     $in_paths = $this->getArgument('paths');

src/workflow/ArcanistDiffWorkflow.php

@@ -7,8 +7,6 @@
  * @task message    Commit and Update Messages
  * @task diffspec   Diff Specification
  * @task diffprop   Diff Properties
- *
- * @group workflow
  */
 final class ArcanistDiffWorkflow extends ArcanistBaseWorkflow {
 

src/workflow/ArcanistDownloadWorkflow.php

@@ -2,8 +2,6 @@
 
 /**
  * Download a file from Phabricator.
- *
- * @group workflow
  */
 final class ArcanistDownloadWorkflow extends ArcanistBaseWorkflow {
 
@@ -36,7 +34,8 @@ EOTEXT
     return array(
       'show' => array(
         'conflicts' => array(
-          'as' => 'Use --show to direct the file to stdout, or --as to direct '.
+          'as' =>
+            'Use --show to direct the file to stdout, or --as to direct '.
             'it to a named location.',
         ),
         'help' => 'Write file to stdout instead of to disk.',

src/workflow/ArcanistExportWorkflow.php

@@ -2,8 +2,6 @@
 
 /**
  * Exports changes from Differential or the working copy to a file.
- *
- * @group workflow
  */
 final class ArcanistExportWorkflow extends ArcanistBaseWorkflow {
 
@@ -84,7 +82,6 @@ EOTEXT
     );
   }
 
-
   protected function didParseArguments() {
     $source = self::SOURCE_LOCAL;
     $requested = 0;
@@ -109,7 +106,6 @@ EOTEXT
         "one change source.");
     }
 
-
     $format = null;
     $requested = 0;
     if ($this->getArgument('git')) {
@@ -167,7 +163,6 @@ EOTEXT
   }
 
   public function run() {
-
     $source = $this->getSource();
 
     switch ($source) {
@@ -218,7 +213,7 @@ EOTEXT
         $bundle->setProjectID($this->getWorkingCopy()->getProjectID());
         $bundle->setBaseRevision(
           $repository_api->getSourceControlBaseRevision());
-        // note we can't get a revision ID for SOURCE_LOCAL
+        // NOTE: we can't get a revision ID for SOURCE_LOCAL
 
         $parser = new PhutilEmailAddress($author);
         $bundle->setAuthorName($parser->getDisplayName());
@@ -273,4 +268,5 @@ EOTEXT
 
     return 0;
   }
+
 }

src/workflow/ArcanistFeatureWorkflow.php

@@ -1,9 +1,8 @@
 <?php
 
 /**
- * Displays user's Git branches or Mercurial bookmarks
+ * Displays user's Git branches or Mercurial bookmarks.
  *
- * @group workflow
  * @concrete-extensible
  */
 class ArcanistFeatureWorkflow extends ArcanistBaseWorkflow {

src/workflow/ArcanistFlagWorkflow.php

@@ -1,8 +1,5 @@
 <?php
 
-/**
- * @group workflow
- */
 final class ArcanistFlagWorkflow extends ArcanistBaseWorkflow {
 
   private static $colorMap = array(
@@ -60,18 +57,18 @@ EOTEXT
     return array(
       '*' => 'objects',
       'clear' => array(
-        'help' => 'Delete the flag on an object.'
+        'help' => 'Delete the flag on an object.',
       ),
       'edit' => array(
-        'help' => 'Edit the flag on an object.'
+        'help' => 'Edit the flag on an object.',
       ),
       'color' => array(
         'param' => 'color',
-        'help' => 'Set the color of a flag.'
+        'help' => 'Set the color of a flag.',
       ),
       'note' => array(
         'param' => 'note',
-        'help' => 'Set the note on a flag.'
+        'help' => 'Set the note on a flag.',
       ),
     );
   }