revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-21 22:32:41 +01:00
Code Issues Releases Wiki Activity

Remove "--lintall" and "--only-new" flags to "arc diff"

Browse source 
Summary:
Ref T13544. These flags change the behavior of the "arc lint" subprocess.

I believe there is no reason to ever use "arc diff --lintall". If you want to find extra warnings to fix, you can use "arc lint --lintall" to express this intent.

Use of "arc diff --only-new" almost certainly means your linters are raising messages at "error" severity which should instead be raised at "warning" severity. If you only care about fixing a particular type of error in changed code, it should be raised as a "warning". The correct remedy is to adjust the severity, not use "--only-new", which is a very broad, slow, complicated hammer.

Test Plan: Searched for "lintall" and "only-new" in this workflow. These flags still exist in "arc lint", but may be changed in the future. Generated this change.

Maniphest Tasks: T13544

Differential Revision: https://secure.phabricator.com/D21298
This commit is contained in:
epriestley 2020-05-30 14:50:04 -07:00
parent 76dc154955
commit d0eb822e37
1 changed files with 0 additions and 25 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
src/workflow/ArcanistDiffWorkflow.php
View file

@ -122,8 +122,6 @@ EOTEXT
'less-context' => null, 'less-context' => null,
'apply-patches' => pht('%s disables lint.', '--raw'), 'apply-patches' => pht('%s disables lint.', '--raw'),
'never-apply-patches' => pht('%s disables lint.', '--raw'), 'never-apply-patches' => pht('%s disables lint.', '--raw'),
'advice' => pht('%s disables lint.', '--raw'),
'lintall' => pht('%s disables lint.', '--raw'),
'create' => pht( 'create' => pht(
'%s and %s both need stdin. Use %s.', '%s and %s both need stdin. Use %s.',
@ -148,8 +146,6 @@ EOTEXT
'less-context' => null, 'less-context' => null,
'apply-patches' => pht('%s disables lint.', '--raw-command'), 'apply-patches' => pht('%s disables lint.', '--raw-command'),
'never-apply-patches' => pht('%s disables lint.', '--raw-command'), 'never-apply-patches' => pht('%s disables lint.', '--raw-command'),
'advice' => pht('%s disables lint.', '--raw-command'),
'lintall' => pht('%s disables lint.', '--raw-command'),
), ),
), ),
'create' => array( 'create' => array(
@ -191,8 +187,6 @@ EOTEXT
'nolint' => array( 'nolint' => array(
'help' => pht('Do not run lint.'), 'help' => pht('Do not run lint.'),
'conflicts' => array( 'conflicts' => array(
'lintall' => pht('%s suppresses lint.', '--nolint'),
'advice' => pht('%s suppresses lint.', '--nolint'),
'apply-patches' => pht('%s suppresses lint.', '--nolint'), 'apply-patches' => pht('%s suppresses lint.', '--nolint'),
'never-apply-patches' => pht('%s suppresses lint.', '--nolint'), 'never-apply-patches' => pht('%s suppresses lint.', '--nolint'),
), ),
@ -222,21 +216,6 @@ EOTEXT
"of lines, this may not work well. With this flag, a diff will ". "of lines, this may not work well. With this flag, a diff will ".
"be created that has only a few lines of context."), "be created that has only a few lines of context."),
), ),
'lintall' => array(
'help' => pht(
'Raise all lint warnings, not just those on lines you changed.'),
'passthru' => array(
'lint' => true,
),
),
'only-new' => array(
'param' => 'bool',
'help' => pht(
'Display only lint messages not present in the original code.'),
'passthru' => array(
'lint' => true,
),
),
'apply-patches' => array( 'apply-patches' => array(
'help' => pht( 'help' => pht(
'Apply patches suggested by lint to the working copy without '. 'Apply patches suggested by lint to the working copy without '.
@ -374,10 +353,6 @@ EOTEXT
'svn' => pht('Subversion does not support commit ranges.'), 'svn' => pht('Subversion does not support commit ranges.'),
'hg' => pht('Mercurial does not support %s yet.', '--head'), 'hg' => pht('Mercurial does not support %s yet.', '--head'),
), ),
'conflicts' => array(
'lintall' => pht('%s suppresses lint.', '--head'),
'advice' => pht('%s suppresses lint.', '--head'),
),
), ),
); );