From d1027c186c1b44e757ea92233d69e60a8cf91f65 Mon Sep 17 00:00:00 2001
From: Jakub Vrana <jakub@vrana.cz>
Date: Thu, 28 Mar 2013 05:04:37 +0000
Subject: [PATCH] Add missing image functions to PHP extension functions list

Summary:
Copied from PHP Manual.

Also fix missing cache key for implicitly linted file.

Test Plan:
  phabricator/ $ arc lint src/applications/files/PhabricatorImageTransformer.php # without GD2

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin, AnhNhan

Differential Revision: https://secure.phabricator.com/D5457
---
 scripts/php_extension_functions.txt   | 14 ++++++++++++++
 src/workflow/ArcanistLintWorkflow.php |  5 ++++-
 2 files changed, 18 insertions(+), 1 deletion(-)

diff --git a/scripts/php_extension_functions.txt b/scripts/php_extension_functions.txt
index 12170be1..a540920f 100644
--- a/scripts/php_extension_functions.txt
+++ b/scripts/php_extension_functions.txt
@@ -111,6 +111,7 @@ imagecreatefrompng
 imagecreatefromstring
 imagecreatefromwbmp
 imagecreatefromxbm
+imagecreatefromxpm
 imagecreatetruecolor
 imagedashedline
 imagedestroy
@@ -124,10 +125,14 @@ imagefilltoborder
 imagefilter
 imagefontheight
 imagefontwidth
+imageftbbox
+imagefttext
 imagegammacorrect
 imagegd
 imagegd2
 imagegif
+imagegrabscreen
+imagegrabwindow
 imageinterlace
 imageistruecolor
 imagejpeg
@@ -137,6 +142,13 @@ imageloadfont
 imagepalettecopy
 imagepng
 imagepolygon
+imagepsbbox
+imagepsencodefont
+imagepsextendfont
+imagepsfreefont
+imagepsloadfont
+imagepsslantfont
+imagepstext
 imagerectangle
 imagerotate
 imagesavealpha
@@ -150,6 +162,8 @@ imagestringup
 imagesx
 imagesy
 imagetruecolortopalette
+imagettfbbox
+imagettftext
 imagetypes
 imagewbmp
 imagexbm
diff --git a/src/workflow/ArcanistLintWorkflow.php b/src/workflow/ArcanistLintWorkflow.php
index b79452e1..054e409e 100644
--- a/src/workflow/ArcanistLintWorkflow.php
+++ b/src/workflow/ArcanistLintWorkflow.php
@@ -548,7 +548,10 @@ EOTEXT
             $cached_path[] = $message->toDictionary();
           }
         }
-        $hash = $file_hashes[$abs_path];
+        $hash = idx($file_hashes, $abs_path);
+        if (!$hash) {
+          $hash = md5_file($abs_path);
+        }
         $cached[$path] = array($hash => array($version => $cached_path));
       }
       $cache[$this->getCacheKey()] = $cached;