revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-29 10:12:41 +01:00
Code Issues Releases Wiki Activity

Remove sourcePath references from Arcanist

Browse source 
Summary: These are meaningless / unreachable after D1491 and nonsense after
D1582. Depends on D1579.

Test Plan: Grepped for 'sourcePath' references.

Reviewers: arice, btrahan

Reviewed By: arice

CC: aran, epriestley

Maniphest Tasks: T838

Differential Revision: https://secure.phabricator.com/D1584
This commit is contained in:
epriestley 2012-02-06 13:08:08 -08:00
parent 84f9148655
commit d3b0b009ce
2 changed files with 1 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/differential/revision/ArcanistDifferentialRevisionRef.php
View file

@ -26,14 +26,12 @@ final class ArcanistDifferentialRevisionRef {
protected $id; protected $id;
protected $name; protected $name;
protected $statusName; protected $statusName;
protected $sourcePath;
public static function newFromDictionary(array $dictionary) { public static function newFromDictionary(array $dictionary) {
$ref = new ArcanistDifferentialRevisionRef(); $ref = new ArcanistDifferentialRevisionRef();
$ref->id = $dictionary['id']; $ref->id = $dictionary['id'];
$ref->name = $dictionary['name']; $ref->name = $dictionary['name'];
$ref->statusName = $dictionary['statusName']; $ref->statusName = $dictionary['statusName'];
$ref->sourcePath = $dictionary['sourcePath'];
return $ref; return $ref;
} }
@ -53,8 +51,4 @@ final class ArcanistDifferentialRevisionRef {
return $this->statusName; return $this->statusName;
} }
public function getSourcePath() {
return $this->sourcePath;
}
} }

9
src/workflow/base/ArcanistBaseWorkflow.php
View file

@ -688,14 +688,7 @@ abstract class ArcanistBaseWorkflow {
$repository_api = $this->getRepositoryAPI(); $repository_api = $this->getRepositoryAPI();
$candidates = array(); $candidates = $revisions;
$cur_path = $repository_api->getPath();
foreach ($revisions as $revision) {
$source_path = $revision->getSourcePath();
if ($source_path == $cur_path) {
$candidates[] = $revision;
}
}
if (count($candidates) == 1) { if (count($candidates) == 1) {
$candidate = reset($candidates); $candidate = reset($candidates);