From d72fad6461b76fa711ebb26bf63c5f99bc49b119 Mon Sep 17 00:00:00 2001 From: epriestley Date: Wed, 3 Mar 2021 13:06:58 -0800 Subject: [PATCH] Add a character marker to the "IMPLICIT COMMITS" warning in "arc land" Summary: Ref T13576. The "implicit commits" prompt in "arc land" shows a list of implicit and non-implicit commits. The implicit commits are marked with a background color, but this doesn't survive if you copy/paste the output into a support ticket. Make my life easier by also marking commits so the marker survives copy/paste. Test Plan: Ran "arc land" with implicit commits, saw a copy-pastable indicator. Maniphest Tasks: T13576 Differential Revision: https://secure.phabricator.com/D21589 --- src/land/engine/ArcanistLandEngine.php | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/land/engine/ArcanistLandEngine.php b/src/land/engine/ArcanistLandEngine.php index 5722073b..3e15f7d6 100644 --- a/src/land/engine/ArcanistLandEngine.php +++ b/src/land/engine/ArcanistLandEngine.php @@ -780,13 +780,15 @@ abstract class ArcanistLandEngine $display_summary = $commit->getDisplaySummary(); if ($is_implicit) { + // NOTE: Mark commits with both a color and a character so the marking + // survives copy/paste. echo tsprintf( - " %s %s\n", + " ! %s %s\n", $display_hash, $display_summary); } else { echo tsprintf( - " %s %s\n", + " %s %s\n", $display_hash, $display_summary); }