revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-12-25 06:50:55 +01:00
Code Issues Releases Wiki Activity

Use ArcanistPhutilLibraryLinter, not ArcanistPhutilModuleLinter

Browse source 
Summary:
  - The library linter works fine on v1 or v2 libraries, so switch to it for all libraries.
  - "arc liberate" on v1 libraries will still invoke the Module linter, and thus generate __init__.php files.

Test Plan: Ran "arc lint". Grepped for module linter.

Reviewers: vrana, btrahan

Reviewed By: vrana

CC: aran

Maniphest Tasks: T1103

Differential Revision: https://secure.phabricator.com/D2620
This commit is contained in:
epriestley 2012-05-31 10:36:00 -07:00
parent 5aef938391
commit d80c4f683e
2 changed files with 4 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/lint/engine/comprehensive/ComprehensiveLintEngine.php
View file

@ -28,17 +28,6 @@ final class ComprehensiveLintEngine extends ArcanistLintEngine {
$paths = $this->getPaths(); $paths = $this->getPaths();
// This needs to go first so that changes to generated files cause module
// linting. This linter also operates on removed files, because removing
// a file changes the static properties of a module.
$module_linter = new ArcanistPhutilModuleLinter();
$linters[] = $module_linter;
foreach ($paths as $path) {
$module_linter->addPath($path);
}
// Remaining lint engines operate on file contents and ignore removed
// files.
foreach ($paths as $key => $path) { foreach ($paths as $key => $path) {
if (!$this->pathExists($path)) { if (!$this->pathExists($path)) {
unset($paths[$key]); unset($paths[$key]);

12
src/lint/engine/phutil/PhutilLintEngine.php
View file

@ -30,17 +30,13 @@ class PhutilLintEngine extends ArcanistLintEngine {
$paths = $this->getPaths(); $paths = $this->getPaths();
// This needs to go first so that changes to generated files cause module $library_linter = new ArcanistPhutilLibraryLinter();
// linting. This linter also operates on removed files, because removing $linters[] = $library_linter;
// a file changes the static properties of a module.
$module_linter = new ArcanistPhutilModuleLinter();
$linters[] = $module_linter;
foreach ($paths as $path) { foreach ($paths as $path) {
$module_linter->addPath($path); $library_linter->addPath($path);
} }
// Remaining lint engines operate on file contents and ignore removed // Remaining linters operate on file contents and ignore removed files.
// files.
foreach ($paths as $key => $path) { foreach ($paths as $key => $path) {
if (!$this->pathExists($path)) { if (!$this->pathExists($path)) {
unset($paths[$key]); unset($paths[$key]);