1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-25 16:22:42 +01:00

Use verbatim commit message if it couldn't be parsed

Summary:
We currently remove an invalid user from Reviewers and similar fields and print a note in the template. There are several problems:

# If I only made a typo in the name then it takes some effort to fix this typo and put the name on the original place (this information is lost).
# The notice is almost invisible and most users will just confirm the message without noticing it.
# If I fill the data in the commit message (and not in the template) then I probably want to treat that as authoritative so I want it to be correct.

Test Plan:
`arc diff` with invalid reviewer in commit message.
`arc diff` on empty commit message.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin, nh

Differential Revision: https://secure.phabricator.com/D2730
This commit is contained in:
vrana 2012-06-12 13:29:05 -07:00
parent 264d915e13
commit d93bb5abd4

View file

@ -1339,13 +1339,18 @@ EOTEXT
$template_is_default = true; $template_is_default = true;
} }
$template = $conduit->callMethodSynchronous( if ($notes) {
'differential.getcommitmessage', $commit = head($this->getRepositoryAPI()->getLocalCommitInformation());
array( $template = $commit['message'];
'revision_id' => null, } else {
'edit' => 'create', $template = $conduit->callMethodSynchronous(
'fields' => $fields, 'differential.getcommitmessage',
)); array(
'revision_id' => null,
'edit' => 'create',
'fields' => $fields,
));
}
} }
if ($included) { if ($included) {