From d9a4293ae734756823b4a3ca202f185c57f3e834 Mon Sep 17 00:00:00 2001 From: epriestley Date: Fri, 3 Aug 2018 12:57:55 -0700 Subject: [PATCH] Consolidate redundant "should should" from some linter help strings in Arcanist Summary: See . Test Plan: Read carefully. Reviewers: amckinley Reviewed By: amckinley Differential Revision: https://secure.phabricator.com/D19561 --- .../xhpast/rules/ArcanistDeprecationXHPASTLinterRule.php | 2 +- .../rules/ArcanistUnsafeDynamicStringXHPASTLinterRule.php | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/lint/linter/xhpast/rules/ArcanistDeprecationXHPASTLinterRule.php b/src/lint/linter/xhpast/rules/ArcanistDeprecationXHPASTLinterRule.php index bc57bb2d..d94192b5 100644 --- a/src/lint/linter/xhpast/rules/ArcanistDeprecationXHPASTLinterRule.php +++ b/src/lint/linter/xhpast/rules/ArcanistDeprecationXHPASTLinterRule.php @@ -20,7 +20,7 @@ final class ArcanistDeprecationXHPASTLinterRule 'xhpast.deprecated.functions' => array( 'type' => 'optional map', 'help' => pht( - 'Functions which should should be considered deprecated.'), + 'Functions which should be considered deprecated.'), ), ); } diff --git a/src/lint/linter/xhpast/rules/ArcanistUnsafeDynamicStringXHPASTLinterRule.php b/src/lint/linter/xhpast/rules/ArcanistUnsafeDynamicStringXHPASTLinterRule.php index bf3c8e51..67cdfcc0 100644 --- a/src/lint/linter/xhpast/rules/ArcanistUnsafeDynamicStringXHPASTLinterRule.php +++ b/src/lint/linter/xhpast/rules/ArcanistUnsafeDynamicStringXHPASTLinterRule.php @@ -21,14 +21,14 @@ final class ArcanistUnsafeDynamicStringXHPASTLinterRule 'xhpast.dynamic-string.classes' => array( 'type' => 'optional map', 'help' => pht( - 'Classes which should should not be used because they represent the '. + 'Classes which should not be used because they represent the '. 'unsafe usage of dynamic strings.'), ), 'xhpast.dynamic-string.functions' => array( 'type' => 'optional map', 'help' => pht( - 'Functions which should should not be used because they represent '. - 'the unsafe usage of dynamic strings.'), + 'Functions which should not be used because they represent the '. + 'unsafe usage of dynamic strings.'), ), );