revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-25 16:22:42 +01:00
Code Issues Releases Wiki Activity

Write to STDERR instead of php://stderr

Browse source 
Summary: See D3661.

Test Plan:
  $ arc diff --raw

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T1261

Differential Revision: https://secure.phabricator.com/D3662
This commit is contained in:
vrana 2012-10-08 16:23:49 -07:00
parent d0ed67ab1d
commit da74127fec
4 changed files with 4 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
scripts/arcanist.php
View file

@ -522,9 +522,7 @@ function arcanist_load_libraries(
if ($must_load) { if ($must_load) {
throw new ArcanistUsageException($error); throw new ArcanistUsageException($error);
} else { } else {
file_put_contents( fwrite(STDERR, phutil_console_wrap('WARNING: '.$error."\n\n"));
'php://stderr',
phutil_console_wrap('WARNING: '.$error."\n\n"));
} }
} catch (PhutilLibraryConflictException $ex) { } catch (PhutilLibraryConflictException $ex) {
if ($ex->getLibrary() != 'arcanist') { if ($ex->getLibrary() != 'arcanist') {

2
src/parser/ArcanistBaseCommitParser.php
View file

@ -48,7 +48,7 @@ final class ArcanistBaseCommitParser {
private function log($message) { private function log($message) {
if ($this->verbose) { if ($this->verbose) {
file_put_contents('php://stderr', $message."\n"); fwrite(STDERR, $message."\n");
} }
} }

2
src/workflow/ArcanistBaseWorkflow.php
View file

@ -1097,7 +1097,7 @@ abstract class ArcanistBaseWorkflow {
* @return void * @return void
*/ */
protected function writeStatusMessage($msg) { protected function writeStatusMessage($msg) {
file_put_contents('php://stderr', $msg); fwrite(STDERR, $msg);
} }
protected function isHistoryImmutable() { protected function isHistoryImmutable() {

2
src/workflow/ArcanistDiffWorkflow.php
View file

@ -775,7 +775,7 @@ EOTEXT
if ($is_raw) { if ($is_raw) {
if ($this->getArgument('raw')) { if ($this->getArgument('raw')) {
file_put_contents('php://stderr', "Reading diff from stdin...\n"); fwrite(STDERR, "Reading diff from stdin...\n");
$raw_diff = file_get_contents('php://stdin'); $raw_diff = file_get_contents('php://stdin');
} else if ($this->getArgument('raw-command')) { } else if ($this->getArgument('raw-command')) {
list($raw_diff) = execx($this->getArgument('raw-command')); list($raw_diff) = execx($this->getArgument('raw-command'));