revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-25 16:22:42 +01:00
Code Issues Releases Wiki Activity

Fix "arc branch" performance regression

Browse source 
Summary: See discussion in T1467. This `log` logs everything in the repo. The old command was `show -s`, I just unthinkingly converted it and it doesn't matter for non-Facebook-sized repositories.

Test Plan: Ran "arc branch".

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T1467

Differential Revision: https://secure.phabricator.com/D2963
This commit is contained in:
epriestley 2012-07-11 16:55:29 -07:00
parent 1ec2d1095b
commit daa210022d
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/workflow/ArcanistBranchWorkflow.php
View file

@ -99,9 +99,13 @@ EOTEXT
array $branches,
ArcanistRepositoryAPI $repository_api) {
// NOTE: "-s" is an option deep in git's diff argument parser that doesn't
// seem to have much documentation and has no long form. It suppresses any
// diff output.
$commits = ipull($branches, 'hash');
list($info) = $repository_api->execxLocal(
'log --format=%C %Ls --',
'show -s --format=%C %Ls',
'%H%x01%ct%x01%T%x01%s%n%b%x02',
$commits);