revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-22 14:52:40 +01:00
Code Issues Releases Wiki Activity

Added test namespace field to ArcanistUnitTestResult

Browse source 
Summary: See https://github.com/facebook/libphutil/issues/34

Test Plan: Run `arc unit`

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Differential Revision: https://secure.phabricator.com/D7952
This commit is contained in:
Joshua Spence 2014-01-13 12:35:33 -08:00 committed by epriestley
parent ef598794a8
commit dd12b72f9a
3 changed files with 19 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/unit/ArcanistUnitTestResult.php
View file

@ -14,6 +14,7 @@ final class ArcanistUnitTestResult {
const RESULT_UNSOUND = 'unsound';
const RESULT_POSTPONED = 'postponed';
private $namespace;
private $name;
private $link;
private $result;
@ -22,6 +23,15 @@ final class ArcanistUnitTestResult {
private $extraData;
private $coverage;
public function setNamespace($namespace) {
$this->namespace = $namespace;
return $this;
}
public function getNamespace() {
return $this->namespace;
}
public function setName($name) {
$this->name = $name;
return $this;

1
src/unit/engine/phutil/ArcanistPhutilTestCase.php
View file

@ -396,6 +396,7 @@ abstract class ArcanistPhutilTestCase {
$result = new ArcanistUnitTestResult();
$result->setCoverage($coverage);
$result->setNamespace(get_class($this));
$result->setName($this->runningTest);
$result->setLink($this->getLink($this->runningTest));
$result->setResult($test_result);

9
src/unit/renderer/ArcanistUnitConsoleRenderer.php
View file

@ -12,10 +12,17 @@ final class ArcanistUnitConsoleRenderer extends ArcanistUnitRenderer {
if ($result_code == ArcanistUnitTestResult::RESULT_PASS) {
$duration = ' '.$this->formatTestDuration($result->getDuration());
}
$test_name = $result->getName();
$test_namespace = $result->getNamespace();
if (strlen($test_namespace)) {
$test_name = $test_namespace.'::'.$test_name;
}
$return = sprintf(
" %s %s\n",
$this->getFormattedResult($result->getResult()).$duration,
$result->getName());
$test_name);
if ($result_code != ArcanistUnitTestResult::RESULT_PASS) {
$return .= $result->getUserData()."\n";