From dd6ffa4a13e711fdc3e920e00b18ed4ca25c7eb9 Mon Sep 17 00:00:00 2001
From: Edward Speyer <edward@fb.com>
Date: Sun, 22 Apr 2012 13:06:32 -0700
Subject: [PATCH] [Tests] Only use concrete TestCases

Summary:
Don't use abstract subclasses of ArcanistPhutilTestCase, only use
concrete ones.

This lets you put common functionality in an abstract BaseTestCase
(which itself is a subclass of ArcanistPhutilTestCase), then implement
concrete subclasses of the BaseTestCase.

Test Plan: Tested with a simple Base -> {Case1, Case2} setup.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Koolvin

Differential Revision: https://secure.phabricator.com/D2300
---
 src/unit/engine/phutil/PhutilUnitTestEngine.php | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/unit/engine/phutil/PhutilUnitTestEngine.php b/src/unit/engine/phutil/PhutilUnitTestEngine.php
index 50b152a8..ec96e7f4 100644
--- a/src/unit/engine/phutil/PhutilUnitTestEngine.php
+++ b/src/unit/engine/phutil/PhutilUnitTestEngine.php
@@ -118,6 +118,7 @@ final class PhutilUnitTestEngine extends ArcanistBaseUnitTestEngine {
         ->setLibrary($test['library'])
         ->setModule($test['module'])
         ->setAncestorClass('ArcanistPhutilTestCase')
+        ->setConcreteOnly(true)
         ->selectAndLoadSymbols();
       foreach ($symbols as $symbol) {
         $run_tests[$symbol['name']] = true;