diff --git a/src/lint/linter/__tests__/ArcanistLinterTestCase.php b/src/lint/linter/__tests__/ArcanistLinterTestCase.php index c023efd1..d4007d2e 100644 --- a/src/lint/linter/__tests__/ArcanistLinterTestCase.php +++ b/src/lint/linter/__tests__/ArcanistLinterTestCase.php @@ -65,7 +65,7 @@ abstract class ArcanistLinterTestCase extends PhutilTestCase { '~~~~~~~~~~')); } - list ($data, $expect, $xform, $config) = array_merge( + list($data, $expect, $xform, $config) = array_merge( $contents, array(null, null)); diff --git a/src/parser/ArcanistBundle.php b/src/parser/ArcanistBundle.php index a4d85581..8586e281 100644 --- a/src/parser/ArcanistBundle.php +++ b/src/parser/ArcanistBundle.php @@ -819,16 +819,91 @@ final class ArcanistBundle extends Phobject { // additional casting.) static $map = array( - '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', - 'A', 'B', 'C', 'D', 'E', 'F', 'G', 'H', 'I', 'J', - 'K', 'L', 'M', 'N', 'O', 'P', 'Q', 'R', 'S', 'T', - 'U', 'V', 'W', 'X', 'Y', 'Z', - 'a', 'b', 'c', 'd', 'e', 'f', 'g', 'h', 'i', 'j', - 'k', 'l', 'm', 'n', 'o', 'p', 'q', 'r', 's', 't', - 'u', 'v', 'w', 'x', 'y', 'z', - '!', '#', '$', '%', '&', '(', ')', '*', '+', '-', - ';', '<', '=', '>', '?', '@', '^', '_', '`', '{', - '|', '}', '~', + '0', + '1', + '2', + '3', + '4', + '5', + '6', + '7', + '8', + '9', + 'A', + 'B', + 'C', + 'D', + 'E', + 'F', + 'G', + 'H', + 'I', + 'J', + 'K', + 'L', + 'M', + 'N', + 'O', + 'P', + 'Q', + 'R', + 'S', + 'T', + 'U', + 'V', + 'W', + 'X', + 'Y', + 'Z', + 'a', + 'b', + 'c', + 'd', + 'e', + 'f', + 'g', + 'h', + 'i', + 'j', + 'k', + 'l', + 'm', + 'n', + 'o', + 'p', + 'q', + 'r', + 's', + 't', + 'u', + 'v', + 'w', + 'x', + 'y', + 'z', + '!', + '#', + '$', + '%', + '&', + '(', + ')', + '*', + '+', + '-', + ';', + '<', + '=', + '>', + '?', + '@', + '^', + '_', + '`', + '{', + '|', + '}', + '~', ); $buf = ''; diff --git a/src/repository/api/ArcanistMercurialAPI.php b/src/repository/api/ArcanistMercurialAPI.php index 4abcea04..33105c20 100644 --- a/src/repository/api/ArcanistMercurialAPI.php +++ b/src/repository/api/ArcanistMercurialAPI.php @@ -250,7 +250,7 @@ final class ArcanistMercurialAPI extends ArcanistRepositoryAPI { list($node, $rev, $full_author, $date, $branch, $tag, $parents, $desc) = explode("\1", $log, 9); - list ($author, $author_email) = $this->parseFullAuthor($full_author); + list($author, $author_email) = $this->parseFullAuthor($full_author); // NOTE: If a commit has only one parent, {parents} returns empty. // If it has two parents, {parents} returns revs and short hashes, not @@ -535,7 +535,7 @@ final class ArcanistMercurialAPI extends ArcanistRepositoryAPI { public function supportsRebase() { if ($this->supportsRebase === null) { - list ($err) = $this->execManualLocal('help rebase'); + list($err) = $this->execManualLocal('help rebase'); $this->supportsRebase = $err === 0; } @@ -544,7 +544,7 @@ final class ArcanistMercurialAPI extends ArcanistRepositoryAPI { public function supportsPhases() { if ($this->supportsPhases === null) { - list ($err) = $this->execManualLocal('help phase'); + list($err) = $this->execManualLocal('help phase'); $this->supportsPhases = $err === 0; }