revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-26 00:32:41 +01:00
Code Issues Releases Wiki Activity

(stable) Promote 2016 Week 43

Browse source
This commit is contained in:
epriestley 2016-10-21 16:10:48 -07:00
commit e17fe43ca3
2 changed files with 17 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/configuration/ArcanistSettings.php
View file

@ -169,6 +169,11 @@ final class ArcanistSettings extends Phobject {
'default' => false, 'default' => false,
'example' => 'false', 'example' => 'false',
), ),
'aliases' => array(
'type' => 'aliases',
'help' => pht(
'Configured command aliases. Use "arc alias" to define aliases.'),
),
); );
} }
@ -263,6 +268,12 @@ final class ArcanistSettings extends Phobject {
break; break;
case 'wild': case 'wild':
break; break;
case 'aliases':
throw new Exception(
pht(
'Use "arc alias" to configure aliases, not "arc set-config".'));
break;
} }
return $value; return $value;
@ -296,6 +307,7 @@ final class ArcanistSettings extends Phobject {
} }
break; break;
case 'wild': case 'wild':
case 'aliases':
break; break;
} }

6
src/unit/engine/NoseTestEngine.php
View file

@ -126,8 +126,12 @@ final class NoseTestEngine extends ArcanistUnitTestEngine {
} }
public function readCoverage($cover_file, $source_path) { public function readCoverage($cover_file, $source_path) {
$coverage_xml = Filesystem::readFile($cover_file);
if (strlen($coverage_xml) < 1) {
return array();
}
$coverage_dom = new DOMDocument(); $coverage_dom = new DOMDocument();
$coverage_dom->loadXML(Filesystem::readFile($cover_file)); $coverage_dom->loadXML($coverage_xml);
$reports = array(); $reports = array();
$classes = $coverage_dom->getElementsByTagName('class'); $classes = $coverage_dom->getElementsByTagName('class');