revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-12-25 23:10:56 +01:00
Code Issues Releases Wiki Activity

Minor change to ArcanistPhutilLibraryLinter

Browse source 
Summary: Ref T5577. Modify `ArcanistPhutilLibraryLinter` to use `PhutilLibraryMapBuilder` instead of using an `ExecFuture` to run `phutil_rebuild_map.php`.

Test Plan: Ran `arc lint`.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: epriestley, Korvin

Maniphest Tasks: T5577

Differential Revision: https://secure.phabricator.com/D9864
This commit is contained in:
Joshua Spence 2014-07-10 07:38:40 +10:00
parent b45142e608
commit e37a76896a
1 changed files with 5 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
src/lint/linter/ArcanistPhutilLibraryLinter.php
View file

@ -30,9 +30,9 @@ final class ArcanistPhutilLibraryLinter extends ArcanistLinter {
public function getLintNameMap() {
return array(
self::LINT_UNKNOWN_SYMBOL => 'Unknown Symbol',
self::LINT_DUPLICATE_SYMBOL => 'Duplicate Symbol',
self::LINT_ONE_CLASS_PER_FILE => 'One Class Per File',
self::LINT_UNKNOWN_SYMBOL => pht('Unknown Symbol'),
self::LINT_DUPLICATE_SYMBOL => pht('Duplicate Symbol'),
self::LINT_ONE_CLASS_PER_FILE => pht('One Class Per File'),
);
}
@ -57,18 +57,10 @@ final class ArcanistPhutilLibraryLinter extends ArcanistLinter {
// itself. This means lint results will accurately reflect the state of
// the working copy.
$root = dirname(phutil_get_library_root('phutil'));
$bin = $root.'/scripts/phutil_rebuild_map.php';
$symbols = array();
foreach ($libs as $lib) {
// Do these one at a time since they individually fanout to saturate
// available system resources.
$future = new ExecFuture(
'php %s --show --quiet --ugly -- %s',
$bin,
phutil_get_library_root($lib));
$symbols[$lib] = $future->resolveJSON();
$root = phutil_get_library_root($lib);
$symbols[$lib] = id(new PhutilLibraryMapBuilder($root))->buildMap();
}
$all_symbols = array();