revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-22 14:52:40 +01:00
Code Issues Releases Wiki Activity

Improve error message from ArcanistXHPASTLinter::LINT_FORMATTED_STRING

Browse source 
Summary: Currently the error message from `ArcanistXHPASTLinter::LINT_FORMATTED_STRING` is slightly wrong, mentioning `xsprintf` instead of the actual `sprintf`-style function which was used. This diff changes the error message to be more correct.

Test Plan: Linted a file containing `sprintf('%s')` and saw a reasonable lint message.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D12871
This commit is contained in:
Joshua Spence 2015-05-18 07:48:03 +10:00
parent 1df248cc2d
commit e3a556af9b
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/lint/linter/ArcanistXHPASTLinter.php
View file

@ -3450,7 +3450,7 @@ final class ArcanistXHPASTLinter extends ArcanistBaseXHPASTLinter {
$this->raiseLintAtNode( $this->raiseLintAtNode(
$call, $call,
self::LINT_FORMATTED_STRING, self::LINT_FORMATTED_STRING,
$ex->getMessage()); str_replace('xsprintf', $name, $ex->getMessage()));
} catch (InvalidArgumentException $ex) { } catch (InvalidArgumentException $ex) {
// Ignore. // Ignore.
} }