revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2025-02-19 18:28:38 +01:00
Code Issues Releases Wiki Activity

Use --no-ext-diff in arc land call to git diff

Browse source 
Summary:
Fixes T11435. This isn't a perfect solution since there's a little code duplication, but a perfect solution is probably a bit more involved.

See T11435 for some discussion. In particular, most `git diff` commands already get this flag via `ArcanistGitAPI->getDiffBaseOptions()`.

Test Plan: Will land this change.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11435

Differential Revision: https://secure.phabricator.com/D16375
This commit is contained in:
epriestley 2016-08-06 06:37:23 -07:00
parent 3aa47195ef
commit e5be662d15
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/land/ArcanistGitLandEngine.php
View file

@ -181,7 +181,10 @@ final class ArcanistGitLandEngine
$this->getTargetFullRef())); $this->getTargetFullRef()));
} }
list($changes) = $api->execxLocal('diff HEAD --'); // TODO: This could probably be cleaner by asking the API a question
// about working copy status instead of running a raw diff command. See
// discussion in T11435.
list($changes) = $api->execxLocal('diff --no-ext-diff HEAD --');
$changes = trim($changes); $changes = trim($changes);
if (!strlen($changes)) { if (!strlen($changes)) {
throw new Exception( throw new Exception(