From e62b23e67deacc24469525cc5dea2b297a5073fb Mon Sep 17 00:00:00 2001
From: Ramkumar Ramachandra <artagnon@gmail.com>
Date: Fri, 22 Nov 2013 18:41:59 +0530
Subject: [PATCH] ArcanistGitAPI: document a git ls-files bug

When a submodule is ignored (ignore=all in .gitconfig),

  $ git ls-files -m

fails to exclude the submodule from the listing. Other commands like

  $ git diff-index --name-only HEAD

exclude it just fine.

See: <https://github.com/facebook/arcanist/pull/120>

Reviewed by: epriestley
---
 src/repository/api/ArcanistGitAPI.php | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/repository/api/ArcanistGitAPI.php b/src/repository/api/ArcanistGitAPI.php
index 5a6f740f..aed2630e 100644
--- a/src/repository/api/ArcanistGitAPI.php
+++ b/src/repository/api/ArcanistGitAPI.php
@@ -474,6 +474,8 @@ final class ArcanistGitAPI extends ArcanistRepositoryAPI {
       ));
 
     // Unstaged changes
+    // TODO: This doesn't exclude ignored submodules.
+    // Upstream bug: http://thread.gmane.org/gmane.comp.version-control.git/238173
     $unstaged_future = $this->buildLocalFuture(
       array(
         'ls-files -m',