revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-10 00:42:40 +01:00
Code Issues Releases Wiki Activity

Drop <project + branch> herusitic from Git

Browse source 
Summary: See rage in T1117. Don't use the <project + branch> heuristic anymore..

Test Plan: Ran "arc diff --strict HEAD^" on a commit stacked on top of this one, got no matches.

Reviewers: btrahan, vrana, simpkins, beng

Reviewed By: btrahan

CC: aran, avive

Maniphest Tasks: T1117

Differential Revision: https://secure.phabricator.com/D2221
This commit is contained in:
epriestley 2012-04-13 10:55:28 -07:00
parent 56cdc31426
commit ea0f737e85
2 changed files with 4 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
src/repository/api/git/ArcanistGitAPI.php
View file

@ -741,19 +741,6 @@ final class ArcanistGitAPI extends ArcanistRepositoryAPI {
'commitHashes' => $hashes,
));
if ($results) {
return $results;
}
// If we still didn't succeed, try to find revisions by branch name.
$project = $this->getWorkingCopyIdentity()->getProjectID();
$results = $conduit->callMethodSynchronous(
'differential.query',
$query + array(
'branches' => array($this->getBranchName()),
'arcanistProjects' => array($project),
));
return $results;
}

5
src/workflow/diff/ArcanistDiffWorkflow.php
View file

@ -1502,7 +1502,10 @@ EOTEXT
$template =
rtrim($comments).
"\n\n".
"# Enter a brief description of the changes included in this update.".
"# Enter a brief description of the changes included in this update.\n".
"#\n".
"# If you intended to create a new revision, use:\n".
"# $ arc diff --create\n".
"\n";
$comments = id(new PhutilInteractiveEditor($template))