From ea6fc7789295fc090ed2dd35dc19bfa464478024 Mon Sep 17 00:00:00 2001 From: Joshua Spence Date: Fri, 29 Apr 2016 08:00:07 +0000 Subject: [PATCH] Fix incorrect variable for linter standards Summary: It is currently not possible to apply multiple linter standards because `$value` was used instead of `$standard`. Test Plan: Was able to apply multiple linter standards. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: eadler, thaiphv, Korvin Differential Revision: https://secure.phabricator.com/D15212 --- src/lint/linter/ArcanistLinter.php | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/lint/linter/ArcanistLinter.php b/src/lint/linter/ArcanistLinter.php index d2695148..6bb02e5d 100644 --- a/src/lint/linter/ArcanistLinter.php +++ b/src/lint/linter/ArcanistLinter.php @@ -574,8 +574,10 @@ abstract class ArcanistLinter extends Phobject { case 'standard': $standards = (array)$value; - foreach ($standards as $standard) { - $standard = ArcanistLinterStandard::getStandard($value, $this); + foreach ($standards as $standard_name) { + $standard = ArcanistLinterStandard::getStandard( + $standard_name, + $this); foreach ($standard->getLinterConfiguration() as $k => $v) { $this->setLinterConfigurationValue($k, $v);