revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-25 00:02:40 +01:00
Code Issues Releases Wiki Activity

Fix PHP 8.1 "strlen(null)" exception in HTTPFutureHTTPResponseStatus

Browse source 
Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

```
ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/arcanist/src/future/http/status/HTTPFutureHTTPResponseStatus.php:16]
```

Closes T15930

Test Plan: Run `arcanist/bin/arc unit --everything` on a PHP >= 8.1 system.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15930

Differential Revision: https://we.phorge.it/D25810
This commit is contained in:
Andre Klapper 2024-08-26 23:32:52 +02:00
parent 4b7ee1985b
commit ead6759082
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/future/http/status/HTTPFutureHTTPResponseStatus.php
View file

@ -11,6 +11,8 @@ final class HTTPFutureHTTPResponseStatus extends HTTPFutureResponseStatus {
array $headers, array $headers,
$expect = null) { $expect = null) {
// As $body can be null (T15930), make sure this code deals with a string
$body = phutil_string_cast($body);
// NOTE: Avoiding PhutilUTF8StringTruncator here because this isn't lazy // NOTE: Avoiding PhutilUTF8StringTruncator here because this isn't lazy
// and responses may be large. // and responses may be large.
if (strlen($body) > 512) { if (strlen($body) > 512) {